From: jigsaw <jigsaw@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] Add in_flight_bitmask so as to use full 32 bits of tag.
Date: Thu, 13 Nov 2014 08:56:57 +0200 [thread overview]
Message-ID: <CAHVfvh6zLy8pGyuWw5QTKowxoZWgSH2-TpOYEVO-RXqsM9-rdQ@mail.gmail.com> (raw)
In-Reply-To: <1795062.hHiWS5oXJV@xps13>
Hi Thomas,
>>Do you have another commit before this one in your tree?
Yes this patch relies on this one:
http://dpdk.org/ml/archives/dev/2014-November/007943.html
Sorry I didn't make it clear. The new field usr in rte_mbuf was under same
cover letter in v2 of the in_flight_bitmask patch.
Then in_flight_bitmask has a v3 patch, but I didn't include the rte_mbuf in
the same cover letter, coz the usr patch has been ACKed.
thx &
rgds,
-ql
On Thu, Nov 13, 2014 at 2:50 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> Hi,
>
> 2014-11-10 16:44, Qinglai Xiao:
> > With introduction of in_flight_bitmask, the whole 32 bits of tag can be
> > used. Further more, this patch fixed the integer overflow when finding
> > the matched tags.
> > The maximum number workers is now defined as 64, which is length of
> > double-word. The link between number of workers and RTE_MAX_LCORE is
> > now removed. Compile time check is added to ensure the
> > RTE_DISTRIB_MAX_WORKERS is less than or equal to size of double-word.
> >
> > Signed-off-by: Qinglai Xiao <jigsaw@gmail.com>
>
> The patch doesn't apply cleanly and fail to compile:
> lib/librte_distributor/rte_distributor.c:310:27: error: ‘union
> <anonymous>’ has no member named ‘usr’
>
> Do you have another commit before this one in your tree?
>
> --
> Thomas
>
next prev parent reply other threads:[~2014-11-13 6:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 14:44 Qinglai Xiao
2014-11-10 15:13 ` Bruce Richardson
2014-11-10 15:52 ` jigsaw
2014-11-10 16:55 ` Bruce Richardson
2014-11-11 8:53 ` jigsaw
2014-11-12 15:51 ` Bruce Richardson
2014-11-13 11:26 ` Thomas Monjalon
2014-11-13 0:50 ` Thomas Monjalon
2014-11-13 6:56 ` jigsaw [this message]
2014-11-13 9:18 ` Thomas Monjalon
2014-11-13 9:24 ` jigsaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHVfvh6zLy8pGyuWw5QTKowxoZWgSH2-TpOYEVO-RXqsM9-rdQ@mail.gmail.com \
--to=jigsaw@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).