From: Li Feng <fengli@smartx.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [PATCH] eal/linux: enable the hugepage mem dump
Date: Fri, 1 Apr 2022 17:11:15 +0800 [thread overview]
Message-ID: <CAHckoCzBmx4mLQz7n51fKtrD0va6XeOCqkWz=3HwNjvio2=iHg@mail.gmail.com> (raw)
In-Reply-To: <c8c91af2-4a0e-68f6-62c1-bffe392f428a@intel.com>
On Thu, Mar 31, 2022 at 10:47 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 08-Mar-22 9:41 AM, Li Feng wrote:
> > These hugepages include important structures. We should dump these
> > hugepages into a coredump file for debugging when generating a coredump.
> >
> > Signed-off-by: Li Feng <fengli@smartx.com>
> > ---
> > lib/eal/linux/eal_memalloc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c
> > index f8b1588cae..d7c2eb14a1 100644
> > --- a/lib/eal/linux/eal_memalloc.c
> > +++ b/lib/eal/linux/eal_memalloc.c
> > @@ -623,6 +623,8 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
> > goto resized;
> > }
> >
> > + eal_mem_set_dump(va, alloc_sz, true);
> > +
> > /* In linux, hugetlb limitations, like cgroup, are
> > * enforced at fault time instead of mmap(), even
> > * with the option of MAP_POPULATE. Kernel will send
>
> I am amicable to the idea of including allocated hugepage data in core
> dumps, but even with that assumption, i think you're setting the dump
> flag a little too early, and never cleanup if something fails down the line.
>
> Perhaps move this to the very end of the function, after we have
> succeeded in creating a new segment?
Done in the v2, thanks.
>
> --
> Thanks,
> Anatoly
prev parent reply other threads:[~2022-04-01 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 9:41 Li Feng
2022-03-31 14:46 ` Burakov, Anatoly
2022-04-01 9:11 ` Li Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHckoCzBmx4mLQz7n51fKtrD0va6XeOCqkWz=3HwNjvio2=iHg@mail.gmail.com' \
--to=fengli@smartx.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).