From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Nicolas Chautru <nicolas.chautru@intel.com>
Cc: dev <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v1] maintainers: add explicit maintainer for some bbdev PMDs
Date: Wed, 9 Mar 2022 09:44:38 +0100 [thread overview]
Message-ID: <CAJFAV8w0yAjmR3N3sTNcs36Rj+8jdwRJGAyL8jxb1_b8Acd9ow@mail.gmail.com> (raw)
In-Reply-To: <5072825.0vhOF50zNu@thomas>
On Wed, Mar 9, 2022 at 12:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/03/2022 19:51, Nicolas Chautru:
> > These were implicit from DPDK script but adding
> > separate reference to make it explicit
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > MAINTAINERS | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7577834..004ec91 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
> > F: lib/bbdev/
> > F: doc/guides/prog_guide/bbdev.rst
> > F: drivers/baseband/
>
> I think you can remove the above catch-all.
>
> > +F: drivers/baseband/turbo_sw/
> > +F: drivers/baseband/fpga_lte_fec/
> > +F: drivers/baseband/fpga_5gnr_fec/
> > +F: drivers/baseband/acc100/
>
> I would prefer a separate section for Intel baseband drivers.
We now have a baseband drivers section with a NXP driver.
It is more clear to have Intel drivers in this section like we do for
other classes of devices: one section for API, one section for
drivers.
Btw, the baseband drivers section is missing a global T: entry too.
It means that updates on nxp (atm) and any (in the future) bbdev
driver ends up in the main repo scope instead of next-crypto.
>
> > F: doc/guides/bbdevs/
This too is a catch all.
For the API section, I'd rather see:
-F: drivers/baseband/
-F: doc/guides/bbdevs/
+F: doc/guides/bbdevs/features/default.ini
> > F: app/test-bbdev/
> > F: doc/guides/tools/testbbdev.rst
--
David Marchand
prev parent reply other threads:[~2022-03-09 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 18:51 Nicolas Chautru
2022-03-03 18:51 ` Nicolas Chautru
2022-03-04 8:57 ` Bruce Richardson
2022-03-08 23:23 ` Thomas Monjalon
2022-03-09 8:44 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w0yAjmR3N3sTNcs36Rj+8jdwRJGAyL8jxb1_b8Acd9ow@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).