From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11
Date: Thu, 24 Sep 2020 11:32:41 +0200 [thread overview]
Message-ID: <CAJFAV8w5rxPTFPX+WT73nUd9nBkWU6nycKMet4pRhioaJk7wyg@mail.gmail.com> (raw)
In-Reply-To: <20200921133830.1575872-4-ferruh.yigit@intel.com>
On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
>
> build error:
> In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17:
> ../buildtools/pmdinfogen/pmdinfogen.c: In function ‘parse_elf’:
> ../buildtools/pmdinfogen/pmdinfogen.h:78:1:
> warning: this ‘else’ clause does not guard...
> [-Wmisleading-indentation]
> 78 | else \
> | ^~~~
> ../buildtools/pmdinfogen/pmdinfogen.h:83:35:
> note: in expansion of macro ‘CONVERT_NATIVE’
> 83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
> | ^~~~~~~~~~~~~~
> ../buildtools/pmdinfogen/pmdinfogen.c:152:28:
> note: in expansion of macro ‘TO_NATIVE’
> 152 | hdr->e_type = TO_NATIVE(endian, 16, hdr->e_type);
> | ^~~~~~~~~
> ../buildtools/pmdinfogen/pmdinfogen.h:80:9:
> note: ...this statement, but the latter is misleadingly indented
> as if it were guarded by the ‘else’
> 80 | ___x; \
> | ^~~~
>
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Cc: stable@dpdk.org
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> buildtools/pmdinfogen/pmdinfogen.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h
> index 93930e454..38fd3ddcc 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.h
> +++ b/buildtools/pmdinfogen/pmdinfogen.h
> @@ -77,7 +77,7 @@ if ((fend) == ELFDATA2LSB) \
> ___x = le##width##toh(x); \
> else \
> ___x = be##width##toh(x); \
> - ___x; \
> +___x; \
> })
>
> #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x)
> --
> 2.26.2
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2020-09-24 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: " Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
[not found] ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
[not found] ` <CAJFAV8y9zFUAKoqhQxobdQDVPAOny4ie+Cm1fHneEX6g6zdtjw@mail.gmail.com>
[not found] ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
2020-10-08 10:40 ` David Marchand
2020-10-08 11:29 ` Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
2020-09-24 9:31 ` David Marchand
2020-10-04 8:57 ` Asaf Penso
2020-09-24 11:01 ` Phil Yang
2020-10-08 10:48 ` David Marchand
2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
2020-09-24 9:32 ` David Marchand [this message]
2020-10-08 10:48 ` David Marchand
2020-09-25 4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
2020-10-06 12:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w5rxPTFPX+WT73nUd9nBkWU6nycKMet4pRhioaJk7wyg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).