From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>,
Adrian Moreno Zapata <amorenoz@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>,
bnemeth@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3 0/4] net/virtio: make virtqueue struct cache-friendly
Date: Mon, 15 Mar 2021 17:59:10 +0100 [thread overview]
Message-ID: <CAJFAV8wErE2x+-hM495waWgqdw_cCu=j55ZFtW-ahu-U7Vx1hQ@mail.gmail.com> (raw)
In-Reply-To: <20210315164619.372575-1-maxime.coquelin@redhat.com>
On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This series optimizes the cache usage of virtqueue struct,
> by making a "fake" mbuf being dynamically allocated in Rx
> virtnet struct, by removing a useless virtuque pointer
> into the virtnet structs and by moving a few fields
> to pack holes.
>
> With these 3 patches, the virtqueue struct size goes from
> 576 bytes (9 cachelines) to 248 bytes (4 cachelines).
>
> Changes in v3:
> ==============
> - Use rte_zmalloc_socket for fake mbuf alloc (David)
> - Fix typos in commit messages
> - Remove superfluous pointer check befor freeing (David)
> - Fix checkpatch warnings
Once fixed patch 3, you can add for the series,
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
prev parent reply other threads:[~2021-03-15 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:46 Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 1/4] net/virtio: remove reference to virtqueue in vrings Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 2/4] net/virtio: improve queue init error path Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue Maxime Coquelin
2021-03-15 16:57 ` David Marchand
2021-03-15 17:02 ` Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 4/4] net/virtio: pack virtqueue struct Maxime Coquelin
2021-03-15 16:59 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wErE2x+-hM495waWgqdw_cCu=j55ZFtW-ahu-U7Vx1hQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=amorenoz@redhat.com \
--cc=bnemeth@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).