From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com,
jerinjacobk@gmail.com
Subject: Re: [PATCH v5 1/4] eal: add thread set name API operating on rte thread
Date: Wed, 18 Jan 2023 15:50:43 +0100 [thread overview]
Message-ID: <CAJFAV8wN1S5V+MB4_3tkq6p0vZu5GiaK5owRwUp9iruiaGP9Hg@mail.gmail.com> (raw)
In-Reply-To: <1673979709-8613-2-git-send-email-roretzla@linux.microsoft.com>
On Tue, Jan 17, 2023 at 7:21 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Add a rte_thread_set_name that sets the name of an rte_thread_t thread.
> This is a replacement for the rte_thread_setname(pthread_t, ...) which
> exposes platform-specific details.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>
> Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> lib/eal/common/eal_common_thread.c | 9 +++-----
> lib/eal/freebsd/eal.c | 4 +++-
> lib/eal/freebsd/eal_thread.c | 11 +++++++++
> lib/eal/include/rte_thread.h | 17 ++++++++++++++
> lib/eal/linux/eal.c | 8 +++----
> lib/eal/linux/eal_thread.c | 22 ++++++++++++++++++
> lib/eal/version.map | 3 +++
> lib/eal/windows/rte_thread.c | 46 ++++++++++++++++++++++++++++++++++++++
> 8 files changed, 108 insertions(+), 12 deletions(-)
>
[snip]
There is no update in lib/eal/windows/eal.c.
Windows worker threads are not renamed like on Linux/FreeBSD.
I'd rather fix this in this series now that Windows EAL offers such facility.
Either in this current patch, or a followup patch, as you prefer.
> diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c
> index 1c1e9d0..c26659d 100644
> --- a/lib/eal/windows/rte_thread.c
> +++ b/lib/eal/windows/rte_thread.c
> @@ -4,7 +4,9 @@
> */
>
> #include <errno.h>
> +#include <wchar.h>
>
> +#include <rte_eal.h>
> #include <rte_common.h>
> #include <rte_errno.h>
> #include <rte_thread.h>
> @@ -305,6 +307,50 @@ struct thread_routine_ctx {
> return thread_id;
> }
>
> +void
> +rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)
> +{
> + int ret = 0;
> + wchar_t wname[RTE_MAX_THREAD_NAME_LEN];
> + mbstate_t state = {0};
> + size_t rv;
> + HANDLE thread_handle;
> +
> + thread_handle = OpenThread(THREAD_ALL_ACCESS, FALSE,
> + thread_id.opaque_id);
> + if (thread_handle == NULL) {
> + ret = thread_log_last_error("OpenThread()");
> + goto cleanup;
> + }
> +
> + memset(wname, 0, sizeof(wname));
> + rv = mbsrtowcs(wname, &thread_name, RTE_DIM(wname) - 1, &state);
> + if (rv == (size_t)-1) {
> + ret = EILSEQ;
> + goto cleanup;
> + }
> +
> + if (wcslen(wname) < strlen(thread_name))
> + RTE_LOG(DEBUG, EAL, "Truncated thread name\n");
> +
> +#ifndef RTE_TOOLCHAIN_GCC
> + if (FAILED(SetThreadDescription(thread_handle, wname))) {
> + ret = EINVAL;
> + goto cleanup;
> + }
> +#else
> + ret = ENOTSUP;
> + goto cleanup;
> +#endif
> +
> +cleanup:
> + if (thread_handle != NULL)
> + CloseHandle(thread_handle);
> +
> + if (ret != 0)
> + RTE_LOG(DEBUG, EAL, "Failed to set thread name\n");
> +}
> +
> int
> rte_thread_get_priority(rte_thread_t thread_id,
> enum rte_thread_priority *priority)
> --
> 1.8.3.1
>
--
David Marchand
next prev parent reply other threads:[~2023-01-18 14:51 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 19:00 [PATCH 0/5] add lcore set name and get name API Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 1/5] eal: " Tyler Retzlaff
2022-12-07 21:03 ` Stephen Hemminger
2022-12-07 22:33 ` Tyler Retzlaff
2022-12-08 4:07 ` Stephen Hemminger
2022-12-08 17:11 ` Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 2/5] eal: set lcore config thread for lcore main Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 3/5] test: add a unit test for set and get lcore name APIs Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 4/5] eal: remove thread getname API Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 5/5] eal: deprecate rte thread setname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-11 16:09 ` David Marchand
2023-01-12 21:32 ` Tyler Retzlaff
2023-01-13 4:36 ` Jerin Jacob
2023-01-13 17:09 ` Tyler Retzlaff
2023-01-13 18:56 ` Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 2/4] eal: remove thread getname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 3/4] eal: deprecate rte thread setname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 4/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2022-12-14 16:51 ` Morten Brørup
2023-01-10 20:53 ` [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-11 7:55 ` Morten Brørup
2023-01-12 21:55 ` [PATCH v3 " Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-13 18:51 ` [PATCH v4 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-17 7:49 ` Jerin Jacob
2023-01-17 18:22 ` Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-18 14:50 ` David Marchand [this message]
2023-01-17 18:21 ` [PATCH v5 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-18 6:28 ` Jerin Jacob
2023-01-18 14:51 ` David Marchand
2023-01-17 18:21 ` [PATCH v5 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-18 11:49 ` David Marchand
2023-01-18 19:54 ` [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 1/5] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-18 23:13 ` Stephen Hemminger
2023-01-18 23:44 ` Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 2/5] eal: remove thread getname API Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 3/5] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 4/5] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 5/5] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-22 13:55 ` [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t David Marchand
2023-01-23 18:57 ` Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 " Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 1/5] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 15:21 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 2/5] eal: remove thread getname API Tyler Retzlaff
2023-01-24 15:24 ` Thomas Monjalon
2023-01-24 15:33 ` Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 3/5] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 15:25 ` Thomas Monjalon
2023-01-24 15:33 ` Tyler Retzlaff
2023-01-24 15:47 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 4/5] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-24 15:50 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 5/5] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 16:03 ` Thomas Monjalon
2023-01-24 17:42 ` [PATCH v8 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 18:05 ` Thomas Monjalon
2023-01-24 18:21 ` Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-30 15:46 ` Thomas Monjalon
2023-01-30 16:19 ` David Marchand
2023-01-30 20:34 ` Tyler Retzlaff
2023-01-31 9:53 ` David Marchand
2023-01-31 17:09 ` Tyler Retzlaff
2023-01-31 9:54 ` [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wN1S5V+MB4_3tkq6p0vZu5GiaK5owRwUp9iruiaGP9Hg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).