From: David Marchand <david.marchand@redhat.com>
To: Devendra Singh Rawat <dsinghrawat@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Rasesh Mody <rmody@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3 1/5] net/qede: fix minsize build
Date: Wed, 15 Sep 2021 17:16:08 +0200 [thread overview]
Message-ID: <CAJFAV8wPMTdxXB-kTm6po9iyF+bfpS_FgmFzw==xAmO49CLY=Q@mail.gmail.com> (raw)
In-Reply-To: <CO6PR18MB4452D2E1932C938ECEC6240DB6F69@CO6PR18MB4452.namprd18.prod.outlook.com>
On Mon, Aug 9, 2021 at 7:15 AM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
>
>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, August 8, 2021 6:22 PM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com; david.marchand@redhat.com; Rasesh Mody <rmody@marvell.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>
> Subject: [EXT] [PATCH v3 1/5] net/qede: fix minsize build
>
> External Email
>
> ----------------------------------------------------------------------
> Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0:
>
> In function ‘__internal_ram_wr_relaxed’,
> inlined from ‘internal_ram_wr’ at ecore_int_api.h:166:2,
> inlined from ‘qede_update_rx_prod.constprop’ at qede_rxtx.c:736:2:
> drivers/net/qede/base/bcm_osal.h:136:9: error:
> ‘rx_prods’ is used uninitialized [-Werror=uninitialized]
> | rte_write32_relaxed((_val), (_reg_addr))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ecore_int_api.h:151:17: note: in expansion of macro ‘DIRECT_REG_WR_RELAXED’
> | DIRECT_REG_WR_RELAXED(p_hwfn, &((u32 OSAL_IOMEM *)addr)[i],
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/qede/qede_rxtx.c: In function ‘qede_update_rx_prod.constprop’:
> drivers/net/qede/qede_rxtx.c:724:33: note: ‘rx_prods’ declared here
> | struct eth_rx_prod_data rx_prods = { 0 };
> | ^~~~~~~~
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Can you configure your mail client so that it quotes the original mail
with some '> ' prefix?
Your reply confused patchwork which added back a SoB from Thomas.
> ---
> drivers/net/qede/qede_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 298f4e3e42..35cde561ba 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -721,9 +721,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *edev, {
> uint16_t bd_prod = ecore_chain_get_prod_idx(&rxq->rx_bd_ring);
> uint16_t cqe_prod = ecore_chain_get_prod_idx(&rxq->rx_comp_ring);
> - struct eth_rx_prod_data rx_prods = { 0 };
> + struct eth_rx_prod_data rx_prods;
>
> /* Update producers */
> + memset(&rx_prods, 0, sizeof(rx_prods));
> rx_prods.bd_prod = rte_cpu_to_le_16(bd_prod);
> rx_prods.cqe_prod = rte_cpu_to_le_16(cqe_prod);
>
> --
> 2.31.1
>
> ACKed.
Please reply with a full tag so that patchwork catches it.
It saves me some time/brain cycles when applying patches.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-09-15 15:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 21:53 [dpdk-dev] [PATCH] devtools: test different build types Thomas Monjalon
2021-05-21 15:03 ` David Marchand
2021-07-23 20:26 ` Andrew Rybchenko
2021-08-02 22:45 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 0/5] more build tests Thomas Monjalon
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 1/5] net/qede: fix minsize build Thomas Monjalon
2021-08-09 5:15 ` [dpdk-dev] [EXT] " Devendra Singh Rawat
2021-08-09 7:11 ` Rasesh Mody
2021-09-15 15:16 ` David Marchand [this message]
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 2/5] regex/mlx5: " Thomas Monjalon
2021-08-11 8:48 ` Ruifeng Wang
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 3/5] vdpa/mlx5: " Thomas Monjalon
2021-08-09 6:43 ` Matan Azrad
2021-08-11 8:48 ` Ruifeng Wang
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 4/5] test/crypto: " Thomas Monjalon
2021-08-11 8:48 ` Ruifeng Wang
2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 5/5] devtools: test different build types Thomas Monjalon
2021-09-15 20:27 ` [dpdk-dev] [PATCH v3 0/5] more build tests Ferruh Yigit
2021-09-16 7:05 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wPMTdxXB-kTm6po9iyF+bfpS_FgmFzw==xAmO49CLY=Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=rmody@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).