From: David Marchand <david.marchand@redhat.com>
To: fengchengwen <fengchengwen@huawei.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] argparse: add version in symbols map
Date: Tue, 5 Mar 2024 16:02:18 +0100 [thread overview]
Message-ID: <CAJFAV8wfRPPCBSL22phOgTC3rhqrDv08o4WpchMPOSsmu4jaDg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zB7GnH2cj=jm-2DE_BNwi3SNwNmza48N_kuaQmjqJtmA@mail.gmail.com>
On Tue, Mar 5, 2024 at 1:14 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Tue, Mar 5, 2024 at 12:35 PM fengchengwen <fengchengwen@huawei.com> wrote:
> >
> > Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> >
> > BTW: which tool detects this problem?
>
> I found out about those issues while manually inspecting the changes
> on **/version.map since v23.11.
>
> At the moment, there is no tool enforcing that experimental symbols
> must be in a block with a version comment.
>
> Adding a check could be done:
>
> $ git diff
> diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list-symbol.sh
> index a834399816..b76e2417c5 100755
> --- a/buildtools/map-list-symbol.sh
> +++ b/buildtools/map-list-symbol.sh
> @@ -61,8 +61,12 @@ for file in $@; do
> if (current_section == "") {
> next;
> }
> - if ("'$version'" != "" && "'$version'" != current_version) {
> - next;
> + if ("'$version'" != "") {
> + if ("'$version'" == "unset" && current_version != "") {
> + next;
> + } else if ("'$version'" != "unset" &&
> "'$version'" != current_version) {
> + next;
> + }
> }
> gsub(";","");
> if ("'$symbol'" == "all" || $1 == "'$symbol'") {
>
>
> And it catches more issues:
> $ find lib -name 'version.map' -exec ./buildtools/map-list-symbol.sh
> -S EXPERIMENTAL -V unset {} \;
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_encode_json_format
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_reg_all_ethdev
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_global_stats
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_port_stats_ids
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_get_ports_stats_json
> lib/metrics/version.map EXPERIMENTAL rte_metrics_tel_extract_data
> lib/regexdev/version.map EXPERIMENTAL rte_regex_devices
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_attr_get
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_attr_set
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_close
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_configure
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_count
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_dequeue_burst
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_dump
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_enqueue_burst
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_get_dev_id
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_info_get
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_is_valid_dev
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_logtype
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_queue_pair_setup
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_compile_activate
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_export
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_import
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_rule_db_update
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_selftest
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_start
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_stop
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_by_name_get
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_get
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_names_get
> lib/regexdev/version.map EXPERIMENTAL rte_regexdev_xstats_reset
> lib/reorder/version.map EXPERIMENTAL rte_reorder_seqn_dynfield_offset
> lib/mldev/version.map EXPERIMENTAL rte_ml_dequeue_burst
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_close
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_configure
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_count
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_dump
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_info_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_init
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_is_valid_dev
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_logtype
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_queue_pair_setup
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_selftest
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_socket_id
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_start
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stats_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stats_reset
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_stop
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_by_name_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_names_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_dev_xstats_reset
> lib/mldev/version.map EXPERIMENTAL rte_ml_enqueue_burst
> lib/mldev/version.map EXPERIMENTAL rte_ml_io_dequantize
> lib/mldev/version.map EXPERIMENTAL rte_ml_io_quantize
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_info_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_load
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_params_update
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_start
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_stop
> lib/mldev/version.map EXPERIMENTAL rte_ml_model_unload
> lib/mldev/version.map EXPERIMENTAL rte_ml_op_error_get
> lib/mldev/version.map EXPERIMENTAL rte_ml_op_pool_create
> lib/mldev/version.map EXPERIMENTAL rte_ml_op_pool_free
> lib/argparse/version.map EXPERIMENTAL rte_argparse_parse
> lib/argparse/version.map EXPERIMENTAL rte_argparse_parse_type
>
I sent a respin, fixing all existing issues.
If the respin has no objection, I will discard this current patch.
--
David Marchand
prev parent reply other threads:[~2024-03-05 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 10:36 David Marchand
2024-03-05 10:48 ` Bruce Richardson
2024-03-05 11:35 ` fengchengwen
2024-03-05 12:14 ` David Marchand
2024-03-05 15:02 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wfRPPCBSL22phOgTC3rhqrDv08o4WpchMPOSsmu4jaDg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).