From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, mb@smartsharesystems.com, chenbo.xia@outlook.com
Subject: Re: [PATCH 0/7] vhost: ensure vitqueue access status is checked
Date: Thu, 19 Oct 2023 11:49:00 +0200 [thread overview]
Message-ID: <CAJFAV8woqfs-THet7nQhx76Hw4oHLRByuKf5o537gBv2NC1-pQ@mail.gmail.com> (raw)
In-Reply-To: <20230925163610.3307750-1-maxime.coquelin@redhat.com>
Hello Maxime,
On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> Li Feng initially reported segmentation fault in rte_vhost_vring_call()
> because of not checking the virtqueue metadata can be accessed.
>
> This should be achieved by checking the access_ok status field of
> the virtqueue.
>
> This series also takes the opportunity to fix the other APIs.
> This is split in multiple patches to ease LTS maintainers backports,
> but could be squashed if preferred.
>
> Maxime Coquelin (7):
> vhost: fix missing vring call check on virtqueue access
> vhost: fix missing check on virtqueue access
> vhost: fix checking virtqueue access when notifying guest
> vhost: fix check on virtqueue access in async registration
> vhost: Fix check on virtqueue access in in-flight getter
Nit: fix*
> vhost: fix missing lock protection in power monitor API
> vhost: fix checking virtqueue access ins stats API
This series needs some rebasing, and I had a small comment on a first
patch Fixes: tag, but otherwise it lgtm.
--
David Marchand
prev parent reply other threads:[~2023-10-19 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 16:36 Maxime Coquelin
2023-09-25 16:36 ` [PATCH 1/7] vhost: fix missing vring call check on virtqueue access Maxime Coquelin
2023-10-19 7:24 ` David Marchand
2023-10-20 8:40 ` Maxime Coquelin
2023-09-25 16:36 ` [PATCH 2/7] vhost: fix missing " Maxime Coquelin
2023-09-25 16:36 ` [PATCH 3/7] vhost: fix checking virtqueue access when notifying guest Maxime Coquelin
2023-09-25 16:36 ` [PATCH 4/7] vhost: fix check on virtqueue access in async registration Maxime Coquelin
2023-09-25 16:36 ` [PATCH 5/7] vhost: Fix check on virtqueue access in in-flight getter Maxime Coquelin
2023-09-25 16:36 ` [PATCH 6/7] vhost: fix missing lock protection in power monitor API Maxime Coquelin
2023-09-25 16:36 ` [PATCH 7/7] vhost: fix checking virtqueue access ins stats API Maxime Coquelin
2023-10-19 9:49 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8woqfs-THet7nQhx76Hw4oHLRByuKf5o537gBv2NC1-pQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@outlook.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).