From: David Marchand <david.marchand@redhat.com>
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] eal: fix core number validation
Date: Fri, 11 Jan 2019 16:06:50 +0100 [thread overview]
Message-ID: <CAJFAV8wsGUf0rNJK1N_EMe0TBjgn2at+x+1dJ1_Xhn4ySvFAvQ@mail.gmail.com> (raw)
In-Reply-To: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com>
On Fri, Jan 11, 2019 at 3:15 PM Hari Kumar Vemula <
hari.kumarx.vemula@intel.com> wrote:
>
> diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c
> index 2acab9d69..fc45bf953 100644
> --- a/test/test/test_eal_flags.c
> +++ b/test/test/test_eal_flags.c
> @@ -18,6 +18,7 @@
> #include <sys/file.h>
> #include <limits.h>
>
> +#include <rte_per_lcore.h>
> #include <rte_debug.h>
> #include <rte_string_fns.h>
>
> @@ -513,6 +514,16 @@ test_missing_c_flag(void)
> const char *argv25[] = { prgname, prefix, mp_flag,
> "-n", "3", "--lcores",
> "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"};
>
+ /* core number is negative value */
> + const char * const argv26[] = { prgname, prefix, mp_flag,
> + "-n", "3", "--lcores", "-5" };
> + const char * const argv27[] = { prgname, prefix, mp_flag,
> + "-n", "3", "--lcores", "-5-7" };
>
I did not see this before, but you fixed the "-l" eal option, not
"--lcores" option.
So those unit tests are wrong.
> + /* core number is maximum value */
> + const char * const argv28[] = { prgname, prefix, mp_flag,
> + "-n", "3", "--lcores", "RTE_MAX_LCORE+1" };
> + const char * const argv29[] = { prgname, prefix, mp_flag,
> + "-n", "3", "--lcores",
> "1-(RTE_MAX_LCORE+1)" };
>
> if (launch_proc(argv2) != 0) {
> printf("Error - "
>
Passing "RTE_MAX_LCORE+1" is indeed wrong (be it with "-l" or "--lcores"
options), but I would still prefer to check the formatted value of
RTE_MAX_LCORE (no need for that +1, btw).
So please, in next version, test against "-l", RTE_STR(RTE_MAX_LCORE) and
"-l", "1-" RTE_STR(RTE_MAX_LCORE).
Thanks.
--
David Marchand
next prev parent reply other threads:[~2019-01-11 15:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yes>
2019-01-03 12:28 ` [dpdk-stable] [PATCH v2] " Hari kumar Vemula
2019-01-03 13:03 ` David Marchand
2019-01-07 7:05 ` Hari Kumar Vemula
2019-01-07 10:25 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-10 10:11 ` David Marchand
2019-01-11 14:15 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-11 15:06 ` David Marchand [this message]
2019-01-14 10:08 ` [dpdk-stable] [PATCH v5] " Hari Kumar Vemula
2019-01-14 10:28 ` Hari Kumar Vemula
2019-01-14 14:39 ` David Marchand
2019-01-17 10:11 ` [dpdk-stable] [PATCH v6] " Hari Kumar Vemula
2019-01-17 12:13 ` Hari Kumar Vemula
2019-01-17 12:19 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-01-17 12:32 ` David Marchand
2019-01-17 16:29 ` [dpdk-stable] " Thomas Monjalon
2019-01-17 16:31 ` Thomas Monjalon
2019-01-04 13:10 ` [dpdk-stable] [PATCH v2] " Hari kumar Vemula
2019-01-07 13:01 ` [dpdk-stable] [PATCH] net/bonding: fix create bonded device test failure Hari Kumar Vemula
2019-01-07 18:44 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2019-01-08 10:27 ` Ferruh Yigit
2019-01-15 17:37 ` [dpdk-stable] " Pattan, Reshma
2019-01-28 7:28 ` [dpdk-stable] [PATCH v2] " Hari Kumar Vemula
2019-01-31 23:40 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2019-02-05 13:39 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-02-07 13:34 ` Ferruh Yigit
2019-01-08 6:18 ` [dpdk-stable] [PATCH] " Hari Kumar Vemula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wsGUf0rNJK1N_EMe0TBjgn2at+x+1dJ1_Xhn4ySvFAvQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hari.kumarx.vemula@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).