From: David Marchand <david.marchand@redhat.com>
To: Megha Ajmera <megha.ajmera@intel.com>
Cc: dev@dpdk.org, jasvinder.singh@intel.com,
cristian.dumitrescu@intel.com, stable@dpdk.org,
marcinx.danilewicz@intel.com
Subject: Re: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.
Date: Tue, 10 Jan 2023 12:27:33 +0100 [thread overview]
Message-ID: <CAJFAV8wvViM=G7UhmAZ71AEQ4FDZUcmAE5zxcUVpJ_isVh532Q@mail.gmail.com> (raw)
In-Reply-To: <20230109145448.278463-1-megha.ajmera@intel.com>
On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera <megha.ajmera@intel.com> wrote:
>
> Current position of "tv_ov_enable" variable in
tc_ov_enabled*
> rte_sched_subport structure makes the "memory" variable unused.
I did not enter the beast... but my understanding is that some object
internal to rte_sched_subport currently shares location with this
tc_ov_enabled field.
So please find a better title and describe the impact.
>
> Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally")
> CC: marcinx.danilewicz@intel.com
This is stable@dpdk.org material, isn't it?
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> lib/sched/rte_sched.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
> index c91697131d..eaecd7ceb4 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -202,6 +202,9 @@ struct rte_sched_subport {
> uint32_t qsize_add[RTE_SCHED_QUEUES_PER_PIPE];
> uint32_t qsize_sum;
>
> + /* TC oversubscription activation */
> + int tc_ov_enabled;
> +
> struct rte_sched_pipe *pipe;
> struct rte_sched_queue *queue;
> struct rte_sched_queue_extra *queue_extra;
> @@ -210,8 +213,6 @@ struct rte_sched_subport {
> struct rte_mbuf **queue_array;
> uint8_t memory[0] __rte_cache_aligned;
>
> - /* TC oversubscription activation */
> - int tc_ov_enabled;
> } __rte_cache_aligned;
>
> struct rte_sched_port {
--
David Marchand
next prev parent reply other threads:[~2023-01-10 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:54 Megha Ajmera
2023-01-10 11:12 ` Dumitrescu, Cristian
2023-01-10 11:27 ` David Marchand [this message]
2023-02-06 7:43 ` Thomas Monjalon
2023-02-06 9:32 ` Dumitrescu, Cristian
2023-02-07 9:09 ` Ajmera, Megha
2023-02-07 6:10 ` [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport Megha Ajmera
2023-02-19 22:40 ` Thomas Monjalon
2023-02-19 22:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wvViM=G7UhmAZ71AEQ4FDZUcmAE5zxcUVpJ_isVh532Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=marcinx.danilewicz@intel.com \
--cc=megha.ajmera@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).