From: David Marchand <david.marchand@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Igor Ryzhov <iryzhov@nfware.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU
Date: Wed, 16 Oct 2019 12:55:27 +0200 [thread overview]
Message-ID: <CAJFAV8x3=Cqs5G2245iNQs1fMzyQjEtgEXhhOatzsQge5a4icQ@mail.gmail.com> (raw)
In-Reply-To: <e98a2ef4-5db4-bb2b-3e8c-98186135c092@intel.com>
On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/16/2019 7:40 AM, David Marchand wrote:
> > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote:
> >>> Starting with kernel version 4.10, there are new min/max MTU values in
> >>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by
> >>> default. We should be able to change these values to allow MTU more than
> >>> 1500 to be set on KNI.
> >>>
> >>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> >>
> >> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > I intend to change the title as "kni: fix mtu setting with kernels >= 4.10".
> > Does it sound ok to you?
>
> I am not quite sure it is a fix, this patch enables application to pass min/max
> MTU values for kni netdev but existing code is not doing anything wrong.
To me, starting 4.10, we can't set the mtu to something greater than
1500 on a kni netdev, since netdev uses the ETH_DATA_LEN default value
and will refuse a bigger mtu before even calling the change mtu ndo.
Did I understand something wrong?
--
David Marchand
next prev parent reply other threads:[~2019-10-16 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 11:22 Igor Ryzhov
2019-10-11 16:16 ` Ferruh Yigit
2019-10-16 6:40 ` David Marchand
2019-10-16 10:43 ` Ferruh Yigit
2019-10-16 10:55 ` David Marchand [this message]
2019-10-16 14:47 ` David Marchand
2019-10-16 14:59 ` Ferruh Yigit
2019-10-25 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-10-25 18:32 ` Ferruh Yigit
2019-10-27 10:12 ` David Marchand
2019-10-27 19:56 ` Igor Ryzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x3=Cqs5G2245iNQs1fMzyQjEtgEXhhOatzsQge5a4icQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).