From: David Marchand <david.marchand@redhat.com>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
stable@dpdk.org, Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH] common/mlx5: fix DevX register read error severity
Date: Thu, 10 Nov 2022 17:18:32 +0100 [thread overview]
Message-ID: <CAJFAV8x8WFaMnRsM10xNB45t-5q_H+-ev4Vn8oyVU0-APNyMYw@mail.gmail.com> (raw)
In-Reply-To: <20221110130520.15275-1-getelson@nvidia.com>
On Thu, Nov 10, 2022 at 2:06 PM Gregory Etelson <getelson@nvidia.com> wrote:
>
> PMD attempt to read HW UTC counter properties can fail because the feature
> has no support in port FW or mlx5 kernel module.
>
> In that case PMD still can produce correct time-stamps if it runs on core with
> nanosecond time resolution.
>
> Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure")
>
No blank line here.
> Cc: stable@dpdk.org
>
Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
I had tested the same change to pass OVS unit tests.
I did not hit any other error level messages from functions changed in
b0067860959d ("common/mlx5: update log for DevX general command
failure").
So I guess only changing this one is enough.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2022-11-10 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:05 Gregory Etelson
2022-11-10 16:18 ` David Marchand [this message]
2022-11-10 17:17 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x8WFaMnRsM10xNB45t-5q_H+-ev4Vn8oyVU0-APNyMYw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).