From: David Marchand <david.marchand@redhat.com>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: Nipun.Gupta@amd.com, nikhil.agarwal@amd.com, dev@dpdk.org,
Ferruh.Yigit@amd.com, thomas@monjalon.net
Subject: Re: [PATCH v3] bus/cdx: provide driver flag for optional resource mapping
Date: Fri, 29 Sep 2023 17:17:18 +0200 [thread overview]
Message-ID: <CAJFAV8xBJFp7Qsw1GO9J78rU4v+6DVWyAdykYJBxvyCks2EwgA@mail.gmail.com> (raw)
In-Reply-To: <20230711055147.872889-1-abhijit.gangurde@amd.com>
On Tue, Jul 11, 2023 at 7:52 AM Abhijit Gangurde
<abhijit.gangurde@amd.com> wrote:
> @@ -383,10 +384,12 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr,
> CDX_BUS_DEBUG(" probe device %s using driver: %s", dev_name,
> dr->driver.name);
>
> - ret = cdx_vfio_map_resource(dev);
> - if (ret != 0) {
> - CDX_BUS_ERR("CDX map device failed: %d", ret);
> - goto error_map_device;
> + if (dr->drv_flags & RTE_CDX_DRV_NEED_MAPPING) {
> + ret = cdx_vfio_map_resource(dev);
> + if (ret != 0) {
> + CDX_BUS_ERR("CDX map device failed: %d", ret);
> + goto error_map_device;
> + }
> }
>
> /* call the driver probe() function */
> diff --git a/drivers/bus/cdx/rte_bus_cdx.h b/drivers/bus/cdx/rte_bus_cdx.h
> new file mode 100644
> index 0000000000..4ca12f90c4
> --- /dev/null
> +++ b/drivers/bus/cdx/rte_bus_cdx.h
> @@ -0,0 +1,52 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (C) 2023, Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef RTE_BUS_CDX_H
> +#define RTE_BUS_CDX_H
> +
> +/**
> + * @file
> + * CDX device & driver interface
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/* Forward declarations */
> +struct rte_cdx_device;
> +
> +/**
> + * Map the CDX device resources in user space virtual memory address.
> + *
> + * Note that driver should not call this function when flag
> + * RTE_CDX_DRV_NEED_MAPPING is set, as EAL will do that for
> + * you when it's on.
Why should we export this function in the application ABI, if it is
only used by drivers?
> + *
> + * @param dev
> + * A pointer to a rte_cdx_device structure describing the device
> + * to use.
> + *
> + * @return
> + * 0 on success, negative on error and positive if no driver
> + * is found for the device.
> + */
> +__rte_experimental
> +int rte_cdx_map_device(struct rte_cdx_device *dev);
>
--
David Marchand
next prev parent reply other threads:[~2023-09-29 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 10:39 [PATCH] " Abhijit Gangurde
2023-07-04 11:22 ` Gupta, Nipun
2023-07-05 6:52 ` [PATCH v2] " Abhijit Gangurde
2023-07-11 5:51 ` [PATCH v3] " Abhijit Gangurde
2023-07-11 15:05 ` Gupta, Nipun
2023-09-29 15:17 ` David Marchand [this message]
2023-10-04 10:06 ` Gangurde, Abhijit
2023-10-04 12:54 ` David Marchand
2023-10-13 11:51 ` Gangurde, Abhijit
2023-10-13 12:15 ` David Marchand
2023-07-07 8:35 ` [PATCH] " Gupta, Nipun
2023-10-16 9:16 ` [PATCH v4 1/1] " Abhijit Gangurde
2023-10-16 15:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xBJFp7Qsw1GO9J78rU4v+6DVWyAdykYJBxvyCks2EwgA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=Ferruh.Yigit@amd.com \
--cc=Nipun.Gupta@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=dev@dpdk.org \
--cc=nikhil.agarwal@amd.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).