DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file
Date: Thu, 10 Jan 2019 11:44:07 +0100	[thread overview]
Message-ID: <CAJFAV8xCZdV_SE1J281wAXDL_az=ojPqqfprA4eqxVC1aAStww@mail.gmail.com> (raw)
In-Reply-To: <20190110104135.GA4728@bricha3-MOBL.ger.corp.intel.com>

On Thu, Jan 10, 2019 at 11:41 AM Bruce Richardson <
bruce.richardson@intel.com> wrote:

> On Thu, Jan 10, 2019 at 10:34:19AM +0000, Burakov, Anatoly wrote:
> > On 10-Jan-19 10:02 AM, Bruce Richardson wrote:
> > > I also forgot that. However, that does bring up the thought that for
> some
> > > of our headers we may want them available for all libraries even
> before EAL
> > > is compiled up. [I think this hits on the idea Thomas was discussing of
> > > splitting EAL up into two, where we have a core part that is always
> > > compiled first and has no dependencies followed by another which is
> built
> > > later and can have dependencies.]
> > >
> > > For this specific issue, my thought is that we should indeed move
> compat.h
> > > into EAL, but also add the EAL common/include/ path to the global
> include
> > > path for the project, so all EAL headers (e.g. including those with
> defines
> > > for cacheline size, and other common macros) are just always available.
> > > Libs like kvargs and others should be able to use RTE_DIM etc. for
> > > consistency with the rest of DPDK.
> > >
> > > /Bruce
> > >
> >
> > Patches welcome so! :)
> >
> Working on it... :-)
>

I don't think it is that quick to do, so, for the time being, do we go with
this patch ?


-- 
David Marchand

  reply	other threads:[~2019-01-10 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 17:18 Anatoly Burakov
2019-01-09 17:29 ` David Marchand
2019-01-09 20:51   ` Bruce Richardson
2019-01-09 21:36     ` Thomas Monjalon
2019-01-10  8:45       ` Burakov, Anatoly
2019-01-10  8:52         ` Thomas Monjalon
2019-01-10 10:02           ` Bruce Richardson
2019-01-10 10:33             ` Thomas Monjalon
2019-01-10 10:34             ` Burakov, Anatoly
2019-01-10 10:41               ` Bruce Richardson
2019-01-10 10:44                 ` David Marchand [this message]
2019-01-10 10:48                   ` Bruce Richardson
2019-01-10 11:13                     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xCZdV_SE1J281wAXDL_az=ojPqqfprA4eqxVC1aAStww@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).