From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, stable@dpdk.org, dmitry.kozliuk@gmail.com,
stephen@networkplumber.org
Subject: Re: [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it.
Date: Wed, 21 Dec 2022 16:03:20 +0100 [thread overview]
Message-ID: <CAJFAV8xDpVsPWgZKdiqQNS5CwGFrV-haj9cJqxpot4HD6U7GCA@mail.gmail.com> (raw)
In-Reply-To: <1671211000-14856-1-git-send-email-roretzla@linux.microsoft.com>
On Fri, Dec 16, 2022 at 6:16 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Two bugs are fixed to allow this test to build, run & pass.
> * Mark memory configuration complete during rte_eal_init()
> * Use rte thread api to get a proper implementation of thread join.
>
> v2:
> * update commit message to clarify why this test is beneficial on Windows.
> * add missing Fixes tag
>
> Tyler Retzlaff (2):
> eal: add missing call marking memory config complete
> test: enable lcores test on Windows
>
> app/test/test_lcores.c | 28 +++++++++++++---------------
> lib/eal/windows/eal.c | 3 +++
> 2 files changed, 16 insertions(+), 15 deletions(-)
For the series,
Acked-by: David Marchand <david.marchand@redhat.com>
I added review tags from Stephen from v1.
Series applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-12-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1670287169-15325-1-git-send-email-roretzla@linux.microsoft.com>
2022-12-16 17:16 ` Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 1/2] eal: add missing call marking memory config complete Tyler Retzlaff
2022-12-16 17:16 ` [PATCH v2 2/2] test: enable lcores test on Windows Tyler Retzlaff
2022-12-21 15:03 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xDpVsPWgZKdiqQNS5CwGFrV-haj9cJqxpot4HD6U7GCA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).