From: David Marchand <david.marchand@redhat.com>
To: "Maslekar, Omkar" <omkar.maslekar@intel.com>
Cc: dev <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Loftus, Ciara" <ciara.loftus@intel.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v7] eal: add cache-line demote support
Date: Thu, 15 Oct 2020 22:32:21 +0200 [thread overview]
Message-ID: <CAJFAV8xGanDydMZ70z7LQa-E=vFjsJwgSrKtkJ0R4+aq8dvQUg@mail.gmail.com> (raw)
In-Reply-To: <BY5PR11MB4228FCEE4D482BD507CBC65D95020@BY5PR11MB4228.namprd11.prod.outlook.com>
On Thu, Oct 15, 2020 at 4:41 PM Maslekar, Omkar
<omkar.maslekar@intel.com> wrote:
> >> diff --git a/lib/librte_eal/arm/include/rte_prefetch_32.h
> >> b/lib/librte_eal/arm/include/rte_prefetch_32.h
> >> index e53420a..28b3d48 100644
> >> --- a/lib/librte_eal/arm/include/rte_prefetch_32.h
> >> +++ b/lib/librte_eal/arm/include/rte_prefetch_32.h
> >> @@ -10,6 +10,7 @@
> >> #endif
> >>
> >> #include <rte_common.h>
> >> +#include <rte_compat.h>
> >
> >Move rte_compat.h inclusion from the arch headers to the
> >generic/rte_prefetch.h header only.
> I got below build error if I move rte_compat.h inclusion from the arch headers to the generic/rte_prefetch.h header only. I will remove it and send out a new patch v8.
> In file included from ../lib/librte_eal/x86/include/rte_prefetch.h:14:0,
> from ../lib/librte_table/rte_swx_table_em.c:10:
> ../lib/librte_eal/include/generic/rte_prefetch.h:67:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘static’
Please rebase on main as I took Harry patch which was ready.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-10-15 20:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:16 [dpdk-dev] [PATCH] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h Omkar Maslekar
2020-09-10 1:16 ` Omkar Maslekar
2020-09-10 8:55 ` Bruce Richardson
2020-09-10 23:30 ` Maslekar, Omkar
2020-09-10 22:04 ` David Christensen
2020-09-11 16:51 ` [dpdk-dev] [PATCH v2] " Omkar Maslekar
2020-09-11 16:51 ` Omkar Maslekar
2020-09-11 21:22 ` [dpdk-dev] [PATCH v3] " Omkar Maslekar
2020-09-11 21:22 ` Omkar Maslekar
2020-09-22 1:59 ` [dpdk-dev] [PATCH v4] eal: add cache-line demote support Omkar Maslekar
2020-09-22 1:59 ` Omkar Maslekar
2020-09-22 8:28 ` Bruce Richardson
2020-09-22 21:53 ` Maslekar, Omkar
2020-10-01 0:28 ` [dpdk-dev] [PATCH v5] " Omkar Maslekar
2020-10-01 0:28 ` Omkar Maslekar
2020-10-08 7:09 ` David Marchand
2020-10-08 9:02 ` Bruce Richardson
2020-10-12 9:41 ` David Marchand
2020-10-08 13:12 ` Jerin Jacob
2020-10-12 10:19 ` [dpdk-dev] [PATCH v6] " Omkar Maslekar
2020-10-12 10:19 ` Omkar Maslekar
2020-10-12 19:31 ` David Christensen
2020-10-13 2:59 ` Ruifeng Wang
2020-10-13 16:20 ` Bruce Richardson
2020-10-14 1:55 ` Ruifeng Wang
2020-10-14 7:14 ` David Marchand
2020-10-14 7:51 ` Ruifeng Wang
2020-10-13 9:43 ` [dpdk-dev] [PATCH v7] " Omkar Maslekar
2020-10-13 9:43 ` Omkar Maslekar
2020-10-14 7:24 ` Ruifeng Wang
2020-10-15 8:01 ` David Marchand
2020-10-15 14:41 ` Maslekar, Omkar
2020-10-15 20:32 ` David Marchand [this message]
2020-10-15 15:18 ` [dpdk-dev] [PATCH v8] " Omkar Maslekar
2020-10-15 15:18 ` Omkar Maslekar
2020-10-15 23:20 ` [dpdk-dev] [PATCH v9] " Omkar Maslekar
2020-10-15 23:20 ` Omkar Maslekar
2020-10-16 12:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xGanDydMZ70z7LQa-E=vFjsJwgSrKtkJ0R4+aq8dvQUg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=omkar.maslekar@intel.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).