From: David Marchand <david.marchand@redhat.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: "Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Dharmik Thakkar <dharmik.thakkar@arm.com>, dev <dev@dpdk.org>,
nd <nd@arm.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2 3/3] test/hash: free allocated memory
Date: Fri, 28 Jun 2019 10:38:40 +0200 [thread overview]
Message-ID: <CAJFAV8xK+mZEzpZwROXRBf62-oQ66py2L4D=bSh4Yu2a5Y9jDA@mail.gmail.com> (raw)
In-Reply-To: <20190628045254.17614-3-honnappa.nagarahalli@arm.com>
On Fri, Jun 28, 2019 at 6:53 AM Honnappa Nagarahalli <
honnappa.nagarahalli@arm.com> wrote:
> Free allocated memory.
>
> Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
> Cc: stable@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> ---
> app/test/test_hash_readwrite_lf.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_hash_readwrite_lf.c
> b/app/test/test_hash_readwrite_lf.c
> index 12522e265..9b054dec0 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
>
>
[snip]
@@ -653,6 +656,8 @@ test_rwc_reader(__attribute__((unused)) void *arg)
> cycles = rte_rdtsc_precise() - begin;
> rte_atomic64_add(&gread_cycles, cycles);
> rte_atomic64_add(&greads, read_cnt*loop_cnt);
> +
> + rte_free(pos);
> return 0;
> }
>
In this function, there are three other places returning -1 without freeing
pos.
--
David Marchand
next prev parent reply other threads:[~2019-06-28 8:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 3:24 [dpdk-stable] [PATCH 1/3] test/hash: reset global variable to discard old data Honnappa Nagarahalli
2019-06-27 3:24 ` [dpdk-stable] [PATCH 2/3] test/hash: free allocated memory Honnappa Nagarahalli
2019-06-27 8:07 ` David Marchand
2019-06-28 4:59 ` Honnappa Nagarahalli
2019-06-28 8:36 ` David Marchand
2019-06-27 3:24 ` [dpdk-stable] [PATCH 3/3] test/hash: init hash parameters in the correct function Honnappa Nagarahalli
2019-06-27 8:07 ` David Marchand
2019-06-28 4:55 ` Honnappa Nagarahalli
2019-06-28 4:52 ` [dpdk-stable] [PATCH v2 1/3] test/hash: reset global variable to discard old data Honnappa Nagarahalli
2019-06-28 4:52 ` [dpdk-stable] [PATCH v2 2/3] test/hash: init hash parameters in the correct function Honnappa Nagarahalli
2019-06-28 4:52 ` [dpdk-stable] [PATCH v2 3/3] test/hash: free allocated memory Honnappa Nagarahalli
2019-06-28 8:38 ` David Marchand [this message]
2019-07-02 0:27 ` [dpdk-stable] [PATCH v3 1/4] test/hash: reset global variable to discard old data Honnappa Nagarahalli
2019-07-02 0:27 ` [dpdk-stable] [PATCH v3 2/4] test/hash: init hash parameters in the correct function Honnappa Nagarahalli
2019-07-02 0:27 ` [dpdk-stable] [PATCH v3 3/4] test/hash: free allocated memory Honnappa Nagarahalli
2019-07-05 8:46 ` [dpdk-stable] [dpdk-dev] [PATCH v3 1/4] test/hash: reset global variable to discard old data Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xK+mZEzpZwROXRBf62-oQ66py2L4D=bSh4Yu2a5Y9jDA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).