From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Kevin Laatz <kevin.laatz@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally
Date: Mon, 6 Apr 2020 22:16:02 +0200 [thread overview]
Message-ID: <CAJFAV8xL=gHyoZsE=rJ2wOuQR1_Vp-N7zS2xo_6hvsz3GmgnoA@mail.gmail.com> (raw)
In-Reply-To: <20200403141921.10275-1-pbhagavatula@marvell.com>
On Fri, Apr 3, 2020 at 4:20 PM <pbhagavatula@marvell.com> wrote:
> Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API
> flag globally.
This change does not enable the flag globally.
> This changes reduces the clutter across the project while still maintaining
> the functionality of ALLOW_EXPERIMENTAL_API i.e. warning external
> applications about experimental API usage.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
[snip]
> diff --git a/app/meson.build b/app/meson.build
> index 71109cc42..7e9193fc3 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -26,7 +26,6 @@ default_cflags = machine_args
> foreach app:apps
> build = true
> name = app
> - allow_experimental_apis = false
> sources = []
> includes = []
> cflags = default_cflags
> @@ -53,10 +52,7 @@ foreach app:apps
> link_libs = dpdk_static_libraries + dpdk_drivers
> endif
>
> - if allow_experimental_apis
> - cflags += '-DALLOW_EXPERIMENTAL_API'
> - endif
> -
> + cflags += '-DALLOW_EXPERIMENTAL_API'
> executable('dpdk-' + name,
> sources,
> c_args: cflags,
Please apply the same logic in app/ than for drivers/.
This will spare us the special app/test/meson.build thing, which can
be removed too.
[snip]
> diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
> index 000bbf501..9059f9563 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -62,6 +62,12 @@ New Features
>
> * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit.
>
> +* **Enable ALLOW_EXPERIMENTAL_API flag globally.**
> +
> + Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> + meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API
> + flag globally.
> +
Reading this and the sections we have, it does not fit here.
This is not a new feature.
This change only affects DPDK contributors, so let's just drop the
release notes update.
>
> Removed Items
> -------------
[snip]
> diff --git a/lib/meson.build b/lib/meson.build
> index 9c3cc55d5..3bf14fcdf 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -47,7 +47,6 @@ foreach l:libraries
> build = true
> reason = '<unknown reason>' # set if build == false to explain why
> name = l
> - allow_experimental_apis = false
> use_function_versioning = false
> sources = []
> headers = []
> @@ -98,9 +97,7 @@ foreach l:libraries
> static_dep = shared_dep
> else
>
> - if allow_experimental_apis
> - cflags += '-DALLOW_EXPERIMENTAL_API'
> - endif
> + cflags += '-DALLOW_EXPERIMENTAL_API'
> if use_function_versioning
> cflags += '-DRTE_USE_FUNCTION_VERSIONING'
> endif
Ditto, apply same logic than drivers/meson.build
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-04-06 20:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 18:32 [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global Jerin Jacob
2020-04-02 18:32 ` [dpdk-dev] [PATCH v2 2/2] build: makefile " Jerin Jacob
2020-04-03 7:23 ` [dpdk-dev] [PATCH v2 1/2] build: meson " David Marchand
2020-04-03 7:45 ` David Marchand
2020-04-03 8:05 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-04-03 8:18 ` David Marchand
2020-04-03 9:10 ` Bruce Richardson
2020-04-03 9:14 ` David Marchand
2020-04-03 9:35 ` Bruce Richardson
2020-04-03 10:56 ` Thomas Monjalon
2020-04-03 11:02 ` Pavan Nikhilesh Bhagavatula
2020-04-03 10:20 ` [dpdk-dev] " Hemant Agrawal (OSS)
2020-04-03 14:19 ` [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally pbhagavatula
2020-04-06 20:16 ` David Marchand [this message]
2020-04-10 9:03 ` [dpdk-dev] [PATCH v4] build: enable allow experimental API flag pbhagavatula
2020-04-10 12:12 ` David Marchand
2020-04-10 15:48 ` David Marchand
2020-04-13 14:55 ` [dpdk-dev] [PATCH v5] build: disable experimental API check internally David Marchand
2020-04-14 14:23 ` David Marchand
2020-04-17 10:21 ` Trahe, Fiona
2020-04-17 13:23 ` David Marchand
2020-04-17 13:44 ` Trahe, Fiona
2020-04-17 13:54 ` Thomas Monjalon
2020-04-17 13:56 ` David Marchand
2020-04-17 15:05 ` Trahe, Fiona
2020-04-17 15:52 ` Trahe, Fiona
2020-04-18 19:43 ` Chautru, Nicolas
2020-04-19 7:35 ` David Marchand
2020-04-19 16:17 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xL=gHyoZsE=rJ2wOuQR1_Vp-N7zS2xo_6hvsz3GmgnoA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).