From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 2/2] build: prevent accidentally building without NUMA support
Date: Tue, 13 Jun 2023 15:50:06 +0200 [thread overview]
Message-ID: <CAJFAV8xSpaOUFnj+7FNfQKx53LtgO4FfZuBgnW7_0r7KzYpcGg@mail.gmail.com> (raw)
In-Reply-To: <ZIdc7tUj5iq5YWnR@bricha3-MOBL.ger.corp.intel.com>
On Mon, Jun 12, 2023 at 7:59 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Mon, Jun 12, 2023 at 06:14:56PM +0100, Bruce Richardson wrote:
> > When libnuma development package is missing on a system, DPDK can still
> > be built but will be missing much-needed support for NUMA memory
> > management. This may later cause issues at runtime if the resulting
> > binary is run on a NUMA system.
> >
> > We can reduce the incidence of such runtime error by ensuring that, for
> > native builds*, libnuma is present - unless the user actually specifies
> > via "max_numa_nodes" that they don't require NUMA support. Having this
> > as an error condition is also in keeping with what is documented in the
> > Linux GSG doc, where libnuma is listed as a requirement for building
> > DPDK [1].
> >
> > * NOTE: cross-compilation builds have a different logic set, with a
> > separate "numa" value indicating if numa support is necessary.
> >
> > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > ---
> > V2: Limit check to linux only
> > ---
> > config/meson.build | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> I see this patch has failures reported in the CI, due to some of the
> systems not having libnuma installed. I'd view that as a false positive,
> since libnuma is effectively a mandatory requirement for building DPDK to
> run on most systems. [And this patch still provides a way to build without
> it - that way just has to be selected deliberately, rather than it being chosen
> by default, without the user being aware of the omission.]
The Intel CI lab job failing seems to be an issue in their RHEL 8.7 environment.
Can you ping them to figure it out?
For the i386 job in GHA.. either we install a 32bits numa library, or
we can silence this by setting max_numa_nodes to 1.
--
David Marchand
next prev parent reply other threads:[~2023-06-13 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 16:21 [PATCH 1/2] build: change flag variable type to boolean Bruce Richardson
2023-06-12 16:21 ` [PATCH 2/2] build: prevent accidentally building without NUMA support Bruce Richardson
2023-06-12 17:14 ` [PATCH v2 1/2] build: change flag variable type to boolean Bruce Richardson
2023-06-12 17:14 ` [PATCH v2 2/2] build: prevent accidentally building without NUMA support Bruce Richardson
2023-06-12 17:59 ` Bruce Richardson
2023-06-13 13:50 ` David Marchand [this message]
2023-06-13 13:43 ` [PATCH v2 1/2] build: change flag variable type to boolean David Marchand
2023-06-13 13:55 ` Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 0/2] replace int flags with booleans Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 1/2] build: change NUMA flag variable type to boolean Bruce Richardson
2023-06-13 15:33 ` [PATCH v3 2/2] build: change libfdt " Bruce Richardson
2023-06-14 12:42 ` David Marchand
2023-06-15 13:53 ` [PATCH v3 0/2] replace int flags with booleans David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xSpaOUFnj+7FNfQKx53LtgO4FfZuBgnW7_0r7KzYpcGg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).