DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Akhil Goyal <gakhil@marvell.com>,
	Fan Zhang <royzhang1980@gmail.com>
Subject: Re: [PATCH] cryptodev: fix unduly newlines in logs
Date: Fri, 30 Sep 2022 08:42:50 +0200	[thread overview]
Message-ID: <CAJFAV8xT7WD-zYO=JmUD3TYag=J=xPo3_bReNRRrGx3DMkZ6eA@mail.gmail.com> (raw)
In-Reply-To: <20220929120501.428-1-olivier.matz@6wind.com>

On Thu, Sep 29, 2022 at 2:05 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> The CDEV_LOG_* macros already add a '\n' at the end of
> the line. Remove it from format strings to avoid duplicated
> newlines.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

I had the exact same patch in store :-).
We may want to backport it, but otherwise:
Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2022-09-30  6:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 12:05 Olivier Matz
2022-09-30  6:42 ` David Marchand [this message]
2022-09-30 18:47   ` [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xT7WD-zYO=JmUD3TYag=J=xPo3_bReNRRrGx3DMkZ6eA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=olivier.matz@6wind.com \
    --cc=royzhang1980@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).