From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Kai Ji <kai.ji@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
bruce.richardson@intel.com
Subject: Re: [PATCH v3 0/3] remove __typeof__ from expansion of per lcore macros
Date: Wed, 14 Feb 2024 09:19:25 +0100 [thread overview]
Message-ID: <CAJFAV8xUmvMM+noa9PUgwHPDZD5Te9gL6EuLLwGiGcTQbN8thQ@mail.gmail.com> (raw)
In-Reply-To: <1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com>
On Tue, Feb 13, 2024 at 8:12 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> The design of the macros requires a type to be provided to the macro.
>
> By expanding the type parameter inside of typeof it also inadvertently
> allows an expression to be used which appears not to have been intended
> after evaluating the parameter name and existing macro use.
>
> Technically this is an API break but only for applications that were
> using these macros outside of the original design intent.
>
> v3:
> * provide notice in release_24_03.rst about change in macro
> expansion.
> v2:
> * add additional patch to adjust usage for crypto/ipsec_mb
>
> Tyler Retzlaff (3):
> eal: provide type to per lcore macro
> crypto/ipsec_mb: provide type to per lcore macro
> eal: remove typeof from per lcore macros
>
> doc/guides/rel_notes/release_24_03.rst | 5 +++++
> drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +-
> lib/eal/common/eal_common_errno.c | 2 +-
> lib/eal/include/rte_per_lcore.h | 8 ++++----
> 4 files changed, 11 insertions(+), 6 deletions(-)
Thanks Tyler.
Series applied.
--
David Marchand
prev parent reply other threads:[~2024-02-14 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:27 [PATCH 0/2] " Tyler Retzlaff
2023-12-19 17:27 ` [PATCH 1/2] eal: provide type instead of expression to per lcore macro Tyler Retzlaff
2023-12-19 17:27 ` [PATCH 2/2] eal: remove typeof from per lcore macros Tyler Retzlaff
2023-12-19 17:36 ` [PATCH 0/2] remove __typeof__ from expansion of " Bruce Richardson
2024-01-02 23:44 ` [PATCH v2 0/3] " Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 1/3] eal: provide type to per lcore macro Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 2/3] crypto/ipsec_mb: " Tyler Retzlaff
2024-01-02 23:45 ` [PATCH v2 3/3] eal: remove typeof from per lcore macros Tyler Retzlaff
2024-01-08 10:45 ` [PATCH v2 0/3] remove __typeof__ from expansion of " Bruce Richardson
2024-02-13 11:12 ` [PATCH 0/2] " David Marchand
2024-02-13 19:12 ` [PATCH v3 0/3] " Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 1/3] eal: provide type to per lcore macro Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 2/3] crypto/ipsec_mb: " Tyler Retzlaff
2024-02-13 19:12 ` [PATCH v3 3/3] eal: remove typeof from per lcore macros Tyler Retzlaff
2024-02-13 19:32 ` Morten Brørup
2024-02-14 8:19 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xUmvMM+noa9PUgwHPDZD5Te9gL6EuLLwGiGcTQbN8thQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).