From: David Marchand <david.marchand@redhat.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Akhil Goyal <gakhil@marvell.com>
Cc: dev <dev@dpdk.org>, Fan Zhang <roy.fan.zhang@intel.com>,
Brian Dooley <brian.dooley@intel.com>,
Anoob Joseph <anoobj@marvell.com>,
Archana Muniganti <marchana@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test
Date: Mon, 4 Jul 2022 09:48:48 +0200 [thread overview]
Message-ID: <CAJFAV8xVwc_L0S-cq1y6BOs5vkCnF=yYODKJPoDcDitnM=qpsg@mail.gmail.com> (raw)
In-Reply-To: <40cf83ba9d410a387eccfd93c04d9035f71227f2.1656773832.git.gmuthukrishn@marvell.com>
On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> There is wrong size used for allocation of digest buffer which in
> some cases cause memory corruption. Also, fixed places where memory
> leak is observed. This fix would enable sha 384 and 512 NIST vectors
> be supported fully.
>
> Fixes: 93d797d94f1 ("examples/fips_validation: add parsing for sha")
This sha1 is not valid anymore, or maybe Akhil will squash the fix in
the next-crypto tree before reaching main.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> v2:
> - doc update to support 384 and 512 sha.
> ---
> doc/guides/sample_app_ug/fips_validation.rst | 2 +-
> examples/fips_validation/fips_validation_sha.c | 10 ++++++++--
> examples/fips_validation/main.c | 1 +
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/fips_validation.rst b/doc/guides/sample_app_ug/fips_validation.rst
> index 4b68226665..6f4bd34726 100644
> --- a/doc/guides/sample_app_ug/fips_validation.rst
> +++ b/doc/guides/sample_app_ug/fips_validation.rst
> @@ -63,7 +63,7 @@ ACVP
> * AES-CMAC (128,192,256) - AFT
> * AES-XTS (128,256) - AFT
> * HMAC (SHA1, SHA224, SHA256, SHA384, SHA512)
> - * SHA (1,256) - AFT, MCT
> + * SHA (1, 256, 384, 512) - AFT, MCT
>
>
> Application Information
> diff --git a/examples/fips_validation/fips_validation_sha.c b/examples/fips_validation/fips_validation_sha.c
> index a2928618d7..538cb6647a 100644
> --- a/examples/fips_validation/fips_validation_sha.c
> +++ b/examples/fips_validation/fips_validation_sha.c
> @@ -229,13 +229,19 @@ parse_test_sha_json_algorithm(void)
> for (i = 0; i < RTE_DIM(phsc); i++) {
> if (info.interim_info.sha_data.algo == phsc[i].algo) {
> vec.cipher_auth.digest.len = atoi(phsc[i].str);
> - vec.cipher_auth.digest.val = calloc(0, vec.cipher_auth.digest.len * 8);
> + if (vec.cipher_auth.digest.val)
> + free(vec.cipher_auth.digest.val);
Unneeded if().
We just did a tree-wide cleanup to avoid these.
Please don't reintroduce some.
> +
> + vec.cipher_auth.digest.val = calloc(1, vec.cipher_auth.digest.len);
Don't we need to check for allocation success?
> break;
> }
> }
>
> - if (i == RTE_DIM(phsc))
> + if (i == RTE_DIM(phsc)) {
> + free(vec.cipher_auth.digest.val);
> + vec.cipher_auth.digest.val = NULL;
> return -1;
> + }
>
> return 0;
> }
--
David Marchand
next prev parent reply other threads:[~2022-07-04 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 14:51 [PATCH v1] " Gowrishankar Muthukrishnan
2022-07-02 14:58 ` [PATCH v2] " Gowrishankar Muthukrishnan
2022-07-04 7:48 ` David Marchand [this message]
2022-07-04 7:50 ` [EXT] " Akhil Goyal
2022-07-04 8:26 ` Thomas Monjalon
2022-07-04 8:18 ` Gowrishankar Muthukrishnan
2022-07-02 18:44 ` Gowrishankar Muthukrishnan
2022-07-04 7:00 ` Akhil Goyal
2022-07-04 9:55 ` [PATCH v3] " Gowrishankar Muthukrishnan
2022-07-04 10:34 ` Akhil Goyal
2022-07-04 17:32 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xVwc_L0S-cq1y6BOs5vkCnF=yYODKJPoDcDitnM=qpsg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anoobj@marvell.com \
--cc=brian.dooley@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=jerinj@marvell.com \
--cc=marchana@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).