From: David Marchand <david.marchand@redhat.com>
To: Luca Boccassi <luca.boccassi@gmail.com>
Cc: dev <dev@dpdk.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [dpdk-dev] [PATCH] pmdinfo: check for pci.ids in /usr/share/misc
Date: Thu, 19 Mar 2020 15:47:02 +0100 [thread overview]
Message-ID: <CAJFAV8xaSHf2bAC+RggrdLt8ba5_FQcYjmgu8eW8BG2kNXVVVA@mail.gmail.com> (raw)
In-Reply-To: <20200312163027.20760-1-luca.boccassi@gmail.com>
On Thu, Mar 12, 2020 at 5:30 PM <luca.boccassi@gmail.com> wrote:
>
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Debian and Ubuntu switched years ago from /usr/share/hwdata to /usr/share/misc,
> and the former is just a compat symlink now.
> We are starting to get bug reports to nudge us into changing.
> So check the new path first, and the old one as a fallback.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> usertools/dpdk-pmdinfo.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
> index 9d5c6369a0..12f20735e0 100755
> --- a/usertools/dpdk-pmdinfo.py
> +++ b/usertools/dpdk-pmdinfo.py
> @@ -561,7 +561,10 @@ def main(stream=None):
>
> pcifile_default = "./pci.ids" # For unknown OS's assume local file
> if platform.system() == 'Linux':
> - pcifile_default = "/usr/share/hwdata/pci.ids"
> + # hwdata is the legacy location, misc is supported going forward
> + pcifile_default = "/usr/share/misc/pci.ids"
> + if not os.path.exists(pcifile_default):
> + pcifile_default = "/usr/share/hwdata/pci.ids"
> elif platform.system() == 'FreeBSD':
> pcifile_default = "/usr/local/share/pciids/pci.ids"
> if not os.path.exists(pcifile_default):
> --
> 2.20.1
>
LGTM.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2020-03-19 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 16:30 luca.boccassi
2020-03-19 14:47 ` David Marchand [this message]
2020-04-25 20:11 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xaSHf2bAC+RggrdLt8ba5_FQcYjmgu8eW8BG2kNXVVVA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).