From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/2] add checks for tests not in a suite
Date: Tue, 19 Sep 2023 10:29:07 +0200 [thread overview]
Message-ID: <CAJFAV8xb8y1AvpTQm5CLE_U1Wh+AeYLHvG-Z3K-2--vZqVsoVA@mail.gmail.com> (raw)
In-Reply-To: <20230915115206.132198-1-bruce.richardson@intel.com>
On Fri, Sep 15, 2023 at 1:52 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> To help ensure that we don't have "orphaned" tests not in any test
> suites we can add the following checks:
>
> * In developer-mode builds, emit a warning for each test defined using
> REGISTER_TEST_COMMAND
> * In checkpatches, add a check to prevent the addition of new tests
> using the REGISTER_TEST_COMMAND macro
>
> Bruce Richardson (2):
> app/test: emit warning for tests not in a test suite
> devtools: check for tests added without a test suite
>
> app/test/suites/meson.build | 13 ++++++++++++-
> buildtools/get-test-suites.py | 12 +++++++++---
> devtools/checkpatches.sh | 8 ++++++++
> 3 files changed, 29 insertions(+), 4 deletions(-)
The "non_suite_tests" testsuite returned by
buildtools/get-test-suites.py is a bit strange, as it is not a
testsuite from meson pov.
But otherwise, the series looks good to me.
--
David Marchand
next prev parent reply other threads:[~2023-09-19 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 11:52 Bruce Richardson
2023-09-15 11:52 ` [PATCH 1/2] app/test: emit warning for tests not in a test suite Bruce Richardson
2023-09-15 11:52 ` [PATCH 2/2] devtools: check for tests added without " Bruce Richardson
2023-09-15 11:55 ` [PATCH 0/2] add checks for tests not in a suite Bruce Richardson
2023-09-19 8:29 ` David Marchand [this message]
2023-09-19 8:36 ` Bruce Richardson
2023-09-19 9:07 ` David Marchand
2023-09-26 15:01 ` Aaron Conole
2023-09-27 6:30 ` David Marchand
2023-09-27 8:26 ` Bruce Richardson
2023-09-27 9:31 ` David Marchand
2023-09-27 9:56 ` Bruce Richardson
2023-09-27 14:00 ` Aaron Conole
2023-10-02 9:35 ` David Marchand
2023-10-02 9:35 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xb8y1AvpTQm5CLE_U1Wh+AeYLHvG-Z3K-2--vZqVsoVA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).