From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXT] Re: [PATCH 1/2] app/test: add support for optional dependencies
Date: Thu, 28 Sep 2023 16:42:10 +0200 [thread overview]
Message-ID: <CAJFAV8xfwF76-0zdPxSzviKkrJEULFMGO-fZr6hMkuS1R4gZ_w@mail.gmail.com> (raw)
In-Reply-To: <CO6PR18MB4484FCE7BCDF2D67B8864170D8C1A@CO6PR18MB4484.namprd18.prod.outlook.com>
On Thu, Sep 28, 2023 at 3:06 PM Akhil Goyal <gakhil@marvell.com> wrote:
> > > Some tests make optionally use a component but don't require it for
> >
> > s/make //
> >
> > > building. If we include the dependency in the per-file lists, then tests
> > > may be unnecessarily omitted, as the dependency is not required.
> > > On the other hand, removing the optional dependency from the list can
> > > cause build failures, as the test case may include the optional code,
> > > but then fail to build as the build system won't have added the necessary
> > > paths for header inclusion, or the necessary libraries for linking.
> > >
> > > Resolve this by explicitly providing a list of optional dependencies.
> > > Any items in this list will be added to the dependency list if
> > > available, but otherwise won't be involved in enable/disable of specific
> > > tests.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Akhil Goyal <gakhil@marvell.com>
Series applied, thanks for the quick fix Bruce.
--
David Marchand
prev parent reply other threads:[~2023-09-28 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:26 [PATCH] app/test: drop dependency on crypto scheduler driver Bruce Richardson
2023-09-28 9:36 ` [EXT] " Akhil Goyal
2023-09-28 9:45 ` David Marchand
2023-09-28 9:55 ` Bruce Richardson
2023-09-28 11:04 ` [PATCH 1/2] app/test: add support for optional dependencies Bruce Richardson
2023-09-28 11:04 ` [PATCH 2/2] app/test: make crypto scheduler an optional dependency Bruce Richardson
2023-09-28 12:50 ` [PATCH 1/2] app/test: add support for optional dependencies David Marchand
2023-09-28 13:06 ` [EXT] " Akhil Goyal
2023-09-28 14:42 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xfwF76-0zdPxSzviKkrJEULFMGO-fZr6hMkuS1R4gZ_w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).