From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] build: fail if explicitly requested lib is unbuildable
Date: Fri, 1 Sep 2023 16:29:50 +0200 [thread overview]
Message-ID: <CAJFAV8xisF_i-JZG0DyYZ+q99wpe8B3cri1XLyBcGQ9fa23Zsw@mail.gmail.com> (raw)
In-Reply-To: <20230901142332.588856-1-bruce.richardson@intel.com>
On Fri, Sep 1, 2023 at 4:23 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When the user passes a list of desired libraries to build via the
> "enable_libs" option, the expectation is that those libraries should be
> part of the build. However, if those libs have either external or
> internal dependencies, they still may be silently disabled, for example:
> running "meson setup -Denable_libs=security build" will successfully
> run, but the security lib will not be configured as "cryptodev" is
> missing.
>
> We can fix this by setting a flag to indicate when the libraries are
> specified via an enable_libs flag. If so, then we error out when a
> library is unbuildable, giving a suitable error message. For the above
> example case, the "meson setup" run fails with:
>
> Message: Disabling security [lib/security]: missing internal dependency "cryptodev"
>
> lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly requested lib "security".
> Please add missing dependency "cryptodev" to "enable_libs" option
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
I remember setting a enable_drivers=net/af_xdp on a system lacking
libbpf-devel and not getting warned about its absence.
So I suspect enable_drivers is affected by the same issue.
--
David Marchand
next prev parent reply other threads:[~2023-09-01 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 14:23 Bruce Richardson
2023-09-01 14:23 ` [PATCH 2/2] build: fail if explicitly requested driver " Bruce Richardson
2023-09-01 15:41 ` Morten Brørup
2023-09-02 17:24 ` Patrick Robb
2023-09-14 9:42 ` Bruce Richardson
2023-09-01 14:29 ` David Marchand [this message]
2023-09-01 14:30 ` [PATCH 1/2] build: fail if explicitly requested lib " David Marchand
2023-09-01 14:44 ` Bruce Richardson
2023-09-04 13:38 ` David Marchand
2023-09-01 15:40 ` Morten Brørup
2023-09-14 9:53 ` Bruce Richardson
2023-09-19 15:57 ` Bruce Richardson
2023-09-21 7:01 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xisF_i-JZG0DyYZ+q99wpe8B3cri1XLyBcGQ9fa23Zsw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).