From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, Jeff Guo <jia.guo@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] test/interrupt: account for race with callback
Date: Fri, 9 Aug 2019 11:18:25 +0200 [thread overview]
Message-ID: <CAJFAV8xo5wUUWu4szjh--YinA7LaKOibkcaURbTPbGkcna1VtQ@mail.gmail.com> (raw)
In-Reply-To: <20190808173835.5949-1-aconole@redhat.com>
On Thu, Aug 8, 2019 at 7:38 PM Aaron Conole <aconole@redhat.com> wrote:
>
> Because the eal interrupt framework can race when invoking the callback
> and a separate unregister call, the test needs to accommodate the chance
> that the two collide. Do this by checking the return value of unregister
> against the race-condition flag (EAGAIN).
>
> Fixes: f1a6c22424ce ("app/test: update interrupts test")
Not too sure about this tag, but anyway, this is old enough to apply
to every stable releases we have.
Cc: stable@dpdk.org ?
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> NOTE: it's difficult to reproduce this race. I tried a bit, but have
> only seen it sporadically. In Travis environment, the CPU
> resource can be very limited and this test is quite racy.
Managed to reproduce it:
# time (log=/tmp/$$.log; while true; do echo interrupt_autotest
|taskset -c 0-1 ./build-gcc-static/app/test/dpdk-test -l 0-1 >$log
2>&1; grep -q 'Test OK' $log || break; done; cat $log; rm -f $log)
EAL: Detected 8 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: No available hugepages reported in hugepages-1048576kB
EAL: Probing VFIO support...
EAL: PCI device 0000:00:1f.6 on NUMA socket -1
EAL: Invalid NUMA socket, default to 0
EAL: probe driver: 8086:15d7 net_e1000_em
APP: HPET is not enabled, using TSC as default timer
RTE>>interrupt_autotest
Check unknown valid interrupt full path
Check valid UIO interrupt full path
Check valid device event interrupt full path
count=-11 Resource temporarily unavailable
failure occurred during checking valid device event interrupt full path
Clearing for interrupt tests
Test Failed
RTE>>
real 0m38.081s
user 0m35.836s
sys 0m2.171s
>
> app/test/test_interrupts.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c
> index d8c2d8124..233b14a70 100644
> --- a/app/test/test_interrupts.c
> +++ b/app/test/test_interrupts.c
> @@ -370,9 +370,13 @@ test_interrupt_full_path_check(enum test_interrupt_handle_type intr_type)
> rte_delay_ms(TEST_INTERRUPT_CHECK_INTERVAL);
>
> rte_delay_ms(TEST_INTERRUPT_CHECK_INTERVAL);
> - if (rte_intr_callback_unregister(&test_intr_handle,
> - test_interrupt_callback, &test_intr_handle) < 0)
> - return -1;
> + while ((count =
> + rte_intr_callback_unregister(&test_intr_handle,
> + test_interrupt_callback,
> + &test_intr_handle)) < 0) {
> + if (count != -EAGAIN)
> + return -1;
> + }
>
> if (flag == 0) {
> printf("callback has not been called\n");
> --
> 2.21.0
>
With this patch, my loop has been running for more than 10 minutes now.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-08-09 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 17:38 Aaron Conole
2019-08-09 9:18 ` David Marchand [this message]
2019-09-13 15:01 ` Thomas Monjalon
2019-09-13 14:42 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xo5wUUWu4szjh--YinA7LaKOibkcaURbTPbGkcna1VtQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).