From: David Marchand <david.marchand@redhat.com>
To: "Mah, Yock Gen" <yock.gen.mah@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: IOTG DPDK Ref App <iotg.dpdk.ref.app@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH] IGC: Remove I225_I_PHY_ID checking
Date: Thu, 1 Sep 2022 10:22:10 +0200 [thread overview]
Message-ID: <CAJFAV8xo6qf3d24ZzTm81PaDaU-Yjg9qu1tf5L-=+p6frqYCiw@mail.gmail.com> (raw)
In-Reply-To: <MN2PR11MB420613AEDB3309F870C589E5D9789@MN2PR11MB4206.namprd11.prod.outlook.com>
On Thu, Sep 1, 2022 at 10:08 AM Mah, Yock Gen <yock.gen.mah@intel.com> wrote:
>
> >-----Original Message-----
> >From: Zhang, Qi Z <qi.z.zhang@intel.com>
> >Sent: Tuesday, 30 August, 2022 7:17 PM
> >To: IOTG DPDK Ref App <iotg.dpdk.ref.app@intel.com>; dev@dpdk.org
> >Subject: RE: [PATCH] IGC: Remove I225_I_PHY_ID checking
>
> > -----Original Message-----
> > From: iotg.dpdk.ref.app@intel.com <iotg.dpdk.ref.app@intel.com>
> > Sent: Monday, August 29, 2022 4:15 PM
> > To: dev@dpdk.org
> > Subject: [PATCH] IGC: Remove I225_I_PHY_ID checking
> >
> > From: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>
> >
> > i225 devices have only one PHY vendor. There is unnecessary to check
> > _I_PHY_ID during the link establishment and auto-negotiation process,
> > the checking also caused devices like i225-IT failed. This patch is to
> > remove the mentioned unnecessary checking.
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>
>
> >Is this the expected author name?
> Yes, this is expected author name, the PDL email contain all developers working on the patch for better support and response.
This is not acceptable.
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
It is clearly stated that:
"""
The signoff must be a real name and not an alias or nickname. More
than one signoff is allowed.
"""
And all developers involved in the making of a patch must follow the
Developer’s Certificate of Origin.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
In its current form, this patch cannot be merged in the DPDK project.
Besides, please register to the @dev mailing list.
--
David Marchand
next prev parent reply other threads:[~2022-09-01 8:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 8:14 iotg.dpdk.ref.app
2022-08-30 11:17 ` Zhang, Qi Z
2022-08-31 22:42 ` Mah, Yock Gen
2022-09-01 8:22 ` David Marchand [this message]
2022-09-02 7:01 ` David Marchand
2022-08-31 22:51 ` [PATCH v2] " iotg.dpdk.ref.app
2022-09-02 0:18 ` [PATCH v3] " yock.gen.mah
2022-09-04 1:55 ` Zhang, Qi Z
2022-10-11 11:04 ` [PATCH v2] " Kevin Traynor
2022-10-12 7:45 ` Mah, Yock Gen
2022-10-12 8:39 ` Kevin Traynor
2022-10-18 12:54 ` Kevin Traynor
2022-10-18 22:45 ` Mah, Yock Gen
2022-10-19 8:34 ` Kevin Traynor
2022-12-20 15:47 ` Kevin Traynor
2022-12-21 3:01 ` Mah, Yock Gen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xo6qf3d24ZzTm81PaDaU-Yjg9qu1tf5L-=+p6frqYCiw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=iotg.dpdk.ref.app@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=yock.gen.mah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).