From: David Marchand <david.marchand@redhat.com>
To: Bing Zhao <bingz@nvidia.com>
Cc: parav@nvidia.com, xuemingl@nvidia.com,
andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net,
dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
stable@dpdk.org, Gregory Etelson <getelson@nvidia.com>
Subject: Re: [PATCH v2] bus/auxiliary: prevent device from being probed again
Date: Mon, 14 Nov 2022 11:20:00 +0100 [thread overview]
Message-ID: <CAJFAV8xtM=ipX2gDrPMu=u=egAGirqDVN_31A=CduFxcU2cQHA@mail.gmail.com> (raw)
In-Reply-To: <20221109145356.779649-1-bingz@nvidia.com>
On Wed, Nov 9, 2022 at 3:54 PM Bing Zhao <bingz@nvidia.com> wrote:
>
> The device on auxiliary bus doesn't support being probed again
> without being removed firstly. The PMD will detect and return error
> for this unsupported operation. Some of the resources would be
> cleared wrongly. When quitting, there will be unexpected error like
> crash.
>
> To prevent this, the device driver will be checked before probing a
> device.
>
> Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> CC: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Reviewed-by: Gregory Etelson <getelson@nvidia.com>
> Reviewed-by: Matan Azrad <matan@nvidia.com>
> ---
> v2: fix typo
> ---
> drivers/bus/auxiliary/auxiliary_common.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c
> index 6bb1fe7c96..8bc9f20f1b 100644
> --- a/drivers/bus/auxiliary/auxiliary_common.c
> +++ b/drivers/bus/auxiliary/auxiliary_common.c
> @@ -89,6 +89,7 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv,
> {
> enum rte_iova_mode iova_mode;
> int ret;
> + bool already_probed;
>
> if (drv == NULL || dev == NULL)
> return -EINVAL;
> @@ -116,6 +117,13 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv,
> return -EINVAL;
> }
>
> + already_probed = rte_dev_is_probed(&dev->device);
> + if (already_probed) {
No need for this variable, I removed it when applying.
For consistency with other bus code, I also moved this check before
the IOVA validation.
> + RTE_LOG(DEBUG, EAL, "Device %s is already probed on auxiliary bus\n",
> + dev->device.name);
> + return -EEXIST;
> + }
> +
> /* Allocate interrupt instance */
> dev->intr_handle =
> rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_PRIVATE);
> --
> 2.21.0
>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-11-14 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 14:53 Bing Zhao
2022-11-14 10:20 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xtM=ipX2gDrPMu=u=egAGirqDVN_31A=CduFxcU2cQHA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=parav@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).