From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dpdk stable <stable@dpdk.org>,
box.c.chen@intel.com, WenjieX A Li <wenjiex.a.li@intel.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] mempool: use actual IOVA addresses when populating
Date: Tue, 19 Nov 2019 21:56:09 +0100 [thread overview]
Message-ID: <CAJFAV8xwq8LhENALxPpcJV0YYQp_a7q7xPa3sgV-F=dGSUF=gQ@mail.gmail.com> (raw)
In-Reply-To: <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com>
On Thu, Nov 14, 2019 at 2:58 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> Currently, when mempool is being populated, we get IOVA address
> of every segment using rte_mem_virt2iova(). This works for internal
> memory, but does not really work for external memory, and does not
> work on platforms which return RTE_BAD_IOVA as a result of this
> call (such as FreeBSD). Moreover, even when it works, the function
> in question will do unnecessary pagewalks in IOVA as PA mode, as
> it falls back to rte_mem_virt2phy() instead of just doing a lookup in
> internal memseg table.
>
> To fix it, replace the call to first attempt to look through the
> internal memseg table (this takes care of internal and external memory),
> and fall back to rte_mem_virt2iova() when unable to perform VA->IOVA
> translation via memseg table.
>
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Tested-by: Bo Chen <box.c.chen@intel.com>
Series applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-11-19 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 13:58 Anatoly Burakov
2019-11-14 13:58 ` [dpdk-stable] [PATCH 2/2] mempool: remove check for bad IOVA " Anatoly Burakov
2019-11-15 8:48 ` Olivier Matz
2019-11-19 1:45 ` Li, WenjieX A
2019-11-15 8:46 ` [dpdk-stable] [PATCH 1/2] mempool: use actual IOVA addresses " Olivier Matz
2019-11-15 10:12 ` Burakov, Anatoly
2019-11-19 1:45 ` Li, WenjieX A
2019-11-19 20:56 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xwq8LhENALxPpcJV0YYQp_a7q7xPa3sgV-F=dGSUF=gQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=box.c.chen@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=wenjiex.a.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).