From: David Marchand <david.marchand@redhat.com>
To: Elena Agostini <eagostini@nvidia.com>
Cc: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>,
"dev@dpdk.org" <dev@dpdk.org>,
"levendsayar@gmail.com" <levendsayar@gmail.com>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
Date: Fri, 6 Oct 2023 10:09:11 +0200 [thread overview]
Message-ID: <CAJFAV8xznGNQoM7ThW+gOKpEHU+oEcpsrTpBfexbvf5zW9YrgQ@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB4107F4B14B2B73C5F2BD5B30CDCAA@DM6PR12MB4107.namprd12.prod.outlook.com>
Hello,
On Thu, Oct 5, 2023 at 2:44 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> Ack
Please, don't top post.
>
>
>
> Thanks
>
> EA
>
>
>
> From: David Marchand <david.marchand@redhat.com>
> Date: Friday, 29 September 2023 at 16:58
> To: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>
> Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, levendsayar@gmail.com <levendsayar@gmail.com>
> Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> >
> > From: John Romein <romein@astron.nl>
> >
> > getenv needs stdlib.h to be included.
> >
> > Bugzilla ID: 1133
> >
> > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> > Signed-off-by: John Romein <romein@astron.nl>
>
> Thanks for the patch, it seems to be a duplicate of the prior patch
> sent by Levend:
> https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
As I mentionned, this is a duplicate and you just acked the other patch.
Please pay attention.
--
David Marchand
next prev parent reply other threads:[~2023-10-06 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 18:23 Aaron Conole
2023-09-29 14:58 ` David Marchand
2023-10-05 12:43 ` Elena Agostini
2023-10-06 8:09 ` David Marchand [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-12 17:08 John Romein
2023-09-13 11:12 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xznGNQoM7ThW+gOKpEHU+oEcpsrTpBfexbvf5zW9YrgQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=levendsayar@gmail.com \
--cc=romein@astron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).