From: David Marchand <david.marchand@redhat.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev <dev@dpdk.org>,
Lance Richardson <lance.richardson@broadcom.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: set rxq interrupt config to 0
Date: Thu, 1 Jul 2021 21:44:40 +0200 [thread overview]
Message-ID: <CAJFAV8y+-iFDuqwdgbLrWdmf2r-xBRh12X8x7gkSc1D-kCiAAA@mail.gmail.com> (raw)
In-Reply-To: <20210701181253.39373-1-ajit.khaparde@broadcom.com>
On Thu, Jul 1, 2021 at 8:13 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
>
> Set rxq interrupt config to 0 instead of 1.
> Applications can set the rxq interrupt config to 1 or 0 as needed.
> If an application is not interested in handling Rx interrupts and
> prefers to poll Rx rings, there is no need for the PMD to set this
> config option to 1.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 495c6cd21e..bef9605fed 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1011,7 +1011,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
> };
> eth_dev->data->dev_conf.intr_conf.lsc = 1;
>
> - eth_dev->data->dev_conf.intr_conf.rxq = 1;
> + eth_dev->data->dev_conf.intr_conf.rxq = 0;
The application passes a dev_conf structure at configure time.
This structure configures many features, like rx interrupts.
Resetting anything from this configuration in the get_infos op is
wrong, be it 1 or 0.
Idem with LSC.
I don't think enabling LSC works as expected, because this driver does
not report the RTE_ETH_DEV_INTR_LSC capability.
Which leads me to a question for ethdev maintainers.
I am surprised we don't have a capability for rx interrupts, is this
feature advertised through another way than device flags?
--
David Marchand
next prev parent reply other threads:[~2021-07-01 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 18:12 Ajit Khaparde
2021-07-01 19:44 ` David Marchand [this message]
2021-07-02 1:16 ` Ajit Khaparde
2021-07-02 1:24 ` [dpdk-dev] [PATCH v2] net/bnxt: fix rxq interrupt setting Ajit Khaparde
2021-07-02 21:38 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8y+-iFDuqwdgbLrWdmf2r-xBRh12X8x7gkSc1D-kCiAAA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).