DPDK CI discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ci@dpdk.org, Lincoln Lavoie <lylavoie@iol.unh.edu>,
	 "Tu, Lijuan" <lijuan.tu@intel.com>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
	 "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v2] build: increase minimum meson version to 0.53.2
Date: Fri, 7 Oct 2022 21:13:12 +0200	[thread overview]
Message-ID: <CAJFAV8y1bUFjV4zwqhjo16CaPr+9NYSJn=5r1G2HX2gsEfqtHg@mail.gmail.com> (raw)
In-Reply-To: <20221007162404.1117056-1-bruce.richardson@intel.com>

On Fri, Oct 7, 2022 at 6:24 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> This patchset bumps the minimum meson version from 0.49.2 to 0.53.2.
> Ideally, the minimum version should be 0.53 without a point release, but
> some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed
> by commit[2] in 0.53.1. Therefore we use the latest point release from
> 0.53 branch i.e. 0.53.2.
>
> Some new features of interest which can now be used in DPDK with this
> new minimum meson version:
>
> * can do header-file checks directly inside find_library calls, rather
>   than needing a separate check.[v0.50].
> * can pass multiple cross-files at the same time when cross-compiling
>   [v0.51].
> * "alias_target" function, to allow use to give better/shorter names
>   for particular build objects [v0.52].
> * auto-generation of clang-format [v0.50] and clang-tidy[v0.52] targets
>   when those tools are present and config dotfiles are present.
>   Similarly ctags and cscope are added as targets when those tools are
>   present [v0.53]
> * meson module for filesystem operations, so meson can now check for the
>   presence of particlar files or directories [v0.53].
> * "summary" function to provide a configuration summary at the end of
>   the meson run [v0.53].
>
> Plus many other features. See [3] for full details of each version.
>
> [1] https://github.com/mesonbuild/meson/issues/6442
> [2] https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782

Nit: we can shorten this link and keep only 12 chars for hash.
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579

> [3] https://mesonbuild.com/Release-notes.html
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: David Marchand <david.marchand@redhat.com>


Looking at the test reports for this patch, focusing on compilation:
- it looks like Intel envs are already using a recent enough meson,
- the change passes fine in GHA now,
- UNH envs are reporting failures, but that's expected since the
images must be refreshed once this patch is merged,

So from this aspect, I think we are all set to merge this patch.


It seems the "intel-Testing" test is in ... berserk mode and spewing
errors for all patches since 10/03.
No clue if we have an issue in the main branch, and this test logs are useless.

I'll wait for Intel PRC to be back and ignore for now.


-- 
David Marchand


       reply	other threads:[~2022-10-07 19:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220912170747.3128065-1-bruce.richardson@intel.com>
     [not found] ` <20221007162404.1117056-1-bruce.richardson@intel.com>
2022-10-07 19:13   ` David Marchand [this message]
2022-10-10  5:23     ` Tu, Lijuan
2022-10-10  7:48       ` David Marchand
2022-10-13 12:51         ` Tu, Lijuan
2022-10-10 14:53     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y1bUFjV4zwqhjo16CaPr+9NYSJn=5r1G2HX2gsEfqtHg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=ci@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=lylavoie@iol.unh.edu \
    --cc=thomas@monjalon.net \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).