From: David Marchand <david.marchand@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>, dev <dev@dpdk.org>,
Jens Freimann <jfreimann@redhat.com>,
Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] vhost: fix passing destroyed device to destroy callback
Date: Wed, 10 Apr 2019 10:07:44 +0200 [thread overview]
Message-ID: <CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com> (raw)
In-Reply-To: <2419f57d-3283-0fae-745d-002d7ff500e7@samsung.com>
On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets <i.maximets@samsung.com>
wrote:
> On 10.04.2019 10:24, David Marchand wrote:
> > For vhost maintainers, looking at vhost_user_add_connection, aren't we
> leaking a vid on errors ? either when new_connection notifier returns an
> error, or after calling destroy_connection.
>
> I think that you're right.
> I spotted that too yesterday while preparing this patch, just had no time
> to
> check deeper. It should be safe to call 'vhost_destroy_device' in these
> cases.
>
Yes, that's my understanding too.
--
David Marchand
next prev parent reply other threads:[~2019-04-10 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70@eucas1p2.samsung.com>
2019-04-09 13:36 ` Ilya Maximets
2019-04-09 14:25 ` Jens Freimann
2019-04-10 7:24 ` David Marchand
2019-04-10 7:53 ` Ilya Maximets
2019-04-10 8:07 ` David Marchand [this message]
2019-04-11 8:53 ` Ilya Maximets
2019-04-12 4:39 ` Tiwei Bie
2019-04-12 8:11 ` Ilya Maximets
[not found] ` <CGME20190412083233eucas1p181a34d6544869582defba814e4caeb52@eucas1p1.samsung.com>
2019-04-12 8:32 ` [dpdk-stable] [PATCH v2] " Ilya Maximets
2019-04-15 6:21 ` Tiwei Bie
2019-04-17 7:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).