From: David Marchand <david.marchand@redhat.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp
Date: Mon, 14 Sep 2020 11:20:45 +0200 [thread overview]
Message-ID: <CAJFAV8yEaVFo-VfGHOef27AD9Vj_8_gScbVSW_MLHZR8F=z_nA@mail.gmail.com> (raw)
In-Reply-To: <DBAPR08MB58142C7327A23E8E98EB8CFB98230@DBAPR08MB5814.eurprd08.prod.outlook.com>
On Mon, Sep 14, 2020 at 6:38 AM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> <snip>
>
> >
> > When using memcmp function to check data, the third param should be the
> > size of all elements, rather than the number of the elements.
> >
> > Furthermore, do code clean up by moving repeated code inside
> > 'test_ring_mem_cmp' function to validate data and print information of
> > enqueue/dequeue elements if validation fails.
> This patch is fixing 2 things. But only the memcmp issue need to be backported to stable. I would prefer to split this into 2 and mark only the memcmp commit to be backported.
+1
--
David Marchand
next prev parent reply other threads:[~2020-09-14 9:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200729063105.11299-1-feifei.wang2@arm.com>
2020-07-29 6:31 ` [dpdk-stable] [PATCH v1 1/2] ring: fix the misdescription of the param Feifei Wang
2020-07-29 15:59 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 16:24 ` Ananyev, Konstantin
2020-07-29 19:34 ` Honnappa Nagarahalli
2020-07-30 10:16 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-31 5:26 ` [dpdk-stable] " Honnappa Nagarahalli
2020-07-29 6:31 ` [dpdk-stable] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs Feifei Wang
2020-07-29 13:48 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 14:16 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 14:21 ` [dpdk-stable] " David Marchand
2020-07-29 15:03 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 21:24 ` [dpdk-stable] " Honnappa Nagarahalli
2020-07-30 10:28 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-31 6:25 ` Feifei Wang
[not found] ` <20200805061421.13037-1-feifei.wang2@arm.com>
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 1/4] test/ring: fix wrong parameter " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 2/4] test/ring: fix wrong size used in memcmp Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli
2020-08-27 9:05 ` [dpdk-stable] 回复: " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli
2020-08-27 8:54 ` [dpdk-stable] 回复: " Feifei Wang
[not found] ` <20200911161002.19816-1-feifei.wang2@arm.com>
2020-09-11 16:09 ` [dpdk-stable] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 4:28 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 4/6] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 4:31 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp Feifei Wang
2020-09-14 4:37 ` Honnappa Nagarahalli
2020-09-14 9:20 ` David Marchand [this message]
[not found] ` <20200914143350.18650-1-feifei.wang2@arm.com>
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 2/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 4/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 5/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200915062749.21374-1-feifei.wang2@arm.com>
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200920114856.20697-1-feifei.wang2@arm.com>
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yEaVFo-VfGHOef27AD9Vj_8_gScbVSW_MLHZR8F=z_nA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=Feifei.Wang2@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).