From: David Marchand <david.marchand@redhat.com>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Cc: jiayu.hu@intel.com, dev@dpdk.org
Subject: Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame
Date: Mon, 10 Oct 2022 21:32:56 +0200 [thread overview]
Message-ID: <CAJFAV8yLbAkVgo8sBWjcrXEiYAC3Hkyq99UkGhccQX7OPPyYcA@mail.gmail.com> (raw)
In-Reply-To: <20221010175109.44282-1-kumaraparmesh92@gmail.com>
On Mon, Oct 10, 2022 at 7:51 PM Kumara Parameshwaran
<kumaraparamesh92@gmail.com> wrote:
>
> From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
>
> When GRO packets are merged the packet length is used while
> merging the adjacent packets. If the padded bytes are accounted
> we would end up acking unsent TCP segments.
>
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> v1:
> If there is padding to the ethernet frame cases where timestamp is disabled
> the packet length should be validated with the total ip length as packet length
> is used in the GRO merging logic
Please, can you test with current main branch?
We recently merged a fix:
https://git.dpdk.org/dpdk/commit/?id=b8a55871d5af6f5b8694b1cb5eacbc629734e403
--
David Marchand
next prev parent reply other threads:[~2022-10-10 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 17:51 Kumara Parameshwaran
2022-10-10 19:32 ` David Marchand [this message]
[not found] ` <CANxNyasJ7RWk6S9hArfKc=m39huCOgab92sV4DjxDh0VENLf7Q@mail.gmail.com>
2022-10-11 5:47 ` Fwd: " kumaraparameshwaran rathinavel
2022-10-12 1:34 ` Jun Qiu
2022-10-12 7:48 ` kumaraparameshwaran rathinavel
2022-10-12 7:50 ` David Marchand
2022-10-16 7:01 ` Hu, Jiayu
2022-10-17 13:27 ` kumaraparameshwaran rathinavel
2023-10-31 18:49 ` Stephen Hemminger
2022-10-16 14:43 ` [PATCH v2] gro : check for payload length after the trim Kumara Parameshwaran
2022-10-18 8:21 ` Hu, Jiayu
2022-10-26 15:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yLbAkVgo8sBWjcrXEiYAC3Hkyq99UkGhccQX7OPPyYcA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).