From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Narcisa Vasile <navasile@microsoft.com>
Subject: Re: [PATCH v3 3/4] eal: implement functions for get/set thread affinity
Date: Mon, 25 Apr 2022 10:26:58 +0200 [thread overview]
Message-ID: <CAJFAV8yR5wHEtQ=saVCrr7NjjC+7TbD=2eC2zUW4hF8oNf2U_w@mail.gmail.com> (raw)
In-Reply-To: <1649835795-9344-4-git-send-email-roretzla@linux.microsoft.com>
On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> Implement functions for getting/setting thread affinity.
> Threads can be pinned to specific cores by setting their
> affinity attribute.
>
> note: rte_convert_cpuset_to_affinity has a limitation that all cpus of
> the set belong to the same processor group.
>
> Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
[snip]
> diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c
> index d730bb4..032b09f 100644
> --- a/lib/eal/windows/rte_thread.c
> +++ b/lib/eal/windows/rte_thread.c
> @@ -6,7 +6,8 @@
> #include <rte_common.h>
> #include <rte_errno.h>
> #include <rte_thread.h>
> -#include <rte_windows.h>
> +
> +#include "eal_windows.h"
>
> struct eal_tls_key {
> DWORD thread_index;
> @@ -146,3 +147,131 @@ struct eal_tls_key {
> }
> return output;
> }
> +
> +static int
> +rte_convert_cpuset_to_affinity(const rte_cpuset_t *cpuset,
> + PGROUP_AFFINITY affinity)
This is Windows only, static code.
Please don't use rte_ prefix.
For static code, I see no need for a prefix at all.
--
David Marchand
next prev parent reply other threads:[~2022-04-25 8:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:29 [PATCH 0/3] add eal functions for " Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 1/3] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-08 14:01 ` Dmitry Kozlyuk
2022-04-09 8:02 ` Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-08 14:01 ` Dmitry Kozlyuk
2022-04-09 8:56 ` Tyler Retzlaff
2022-04-11 22:52 ` Dmitry Kozlyuk
2022-04-08 8:57 ` [PATCH 0/3] add eal functions for thread affinity David Marchand
2022-04-08 13:46 ` Tyler Retzlaff
2022-04-11 7:32 ` David Marchand
2022-04-12 10:43 ` [PATCH v2 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-12 17:26 ` Menon, Ranjit
2022-04-13 7:07 ` Tyler Retzlaff
2022-04-25 8:25 ` David Marchand
2022-04-25 8:52 ` Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-13 7:30 ` Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-25 8:26 ` David Marchand
2022-04-25 8:53 ` Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-25 8:26 ` David Marchand [this message]
2022-04-25 8:55 ` Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-26 7:50 ` [PATCH v4 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-26 7:50 ` [PATCH v4 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-04-26 7:50 ` [PATCH v4 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-04-26 7:50 ` [PATCH v4 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-05-03 9:38 ` Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-04 22:55 ` Konstantin Ananyev
2022-05-05 7:11 ` Tyler Retzlaff
2022-05-06 19:37 ` Konstantin Ananyev
2022-05-07 8:25 ` Morten Brørup
2022-05-07 13:57 ` Konstantin Ananyev
2022-05-07 19:47 ` Morten Brørup
2022-05-10 21:52 ` Konstantin Ananyev
2022-05-11 7:17 ` Tyler Retzlaff
2022-05-11 7:36 ` Morten Brørup
2022-05-11 22:27 ` Konstantin Ananyev
2022-05-04 15:46 ` [PATCH v5 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-15 22:02 ` Konstantin Ananyev
2022-05-16 6:21 ` Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-19 15:05 ` [PATCH v6 0/3] add eal functions for thread affinity and self David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yR5wHEtQ=saVCrr7NjjC+7TbD=2eC2zUW4hF8oNf2U_w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=navasile@microsoft.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).