From: David Marchand <david.marchand@redhat.com>
To: fengchengwen <fengchengwen@huawei.com>
Cc: dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array
Date: Wed, 20 Oct 2021 11:55:04 +0200 [thread overview]
Message-ID: <CAJFAV8yRzESS=xXhrcUv-PjsyP_JQA9XuRELKdSfNWTsnR37Tw@mail.gmail.com> (raw)
In-Reply-To: <9510b844-5aec-43e6-b324-2358a4f52042@huawei.com>
On Wed, Oct 20, 2021 at 11:47 AM fengchengwen <fengchengwen@huawei.com> wrote:
>
> On 2021/10/20 14:59, David Marchand wrote:
> > No need to expose rte_dma_devices out of the dmadev library.
> > Existing helpers should be enough, and inlines make use of
> > rte_dma_fp_objs.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > app/test/test_dmadev.c | 5 +++--
> > lib/dmadev/rte_dmadev.c | 2 +-
> > lib/dmadev/rte_dmadev_pmd.h | 2 --
> > lib/dmadev/version.map | 1 -
> > 4 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
> > index 1e327bd45f..8b58256afc 100644
> > --- a/app/test/test_dmadev.c
> > +++ b/app/test/test_dmadev.c
> > @@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id)
> > };
> > const int vchan = 0;
> >
> > + rte_dma_info_get(dev_id, &info);
>
> suggest declare info as: struct rte_dma_stats info = { 0 };
> so that the following %s will display NULL if rte_dma_info_get call fail.
The problem is more generic.
Other info fields are used by the test.
If rte_dma_info_get can fail, its return code must be checked.
Worth a followup patch, can you send it?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-10-20 9:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:59 David Marchand
2021-10-20 6:59 ` [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers David Marchand
2021-10-20 9:40 ` Bruce Richardson
2021-10-20 9:47 ` [dpdk-dev] [PATCH 1/2] dmadev: hide devices array fengchengwen
2021-10-20 9:55 ` David Marchand [this message]
2021-10-20 10:01 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 1/3] " Chengwen Feng
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API Chengwen Feng
2021-10-21 13:43 ` David Marchand
2021-10-21 14:03 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode Chengwen Feng
2021-10-21 13:42 ` David Marchand
2021-10-21 14:04 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 20:20 ` David Marchand
2021-10-21 14:03 ` [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array Kevin Laatz
2021-10-26 6:04 ` Radha Mohan
2021-10-26 6:20 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yRzESS=xXhrcUv-PjsyP_JQA9XuRELKdSfNWTsnR37Tw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).