From: David Marchand <david.marchand@redhat.com>
To: Jeff Guo <jia.guo@intel.com>
Cc: bernard.iremonger@intel.com, Wenzhuo Lu <wenzhuo.lu@intel.com>,
shahafs@mellanox.com, Thomas Monjalon <thomas@monjalon.net>,
matan@mellanox.com, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
konstantin.ananyev@intel.com, dev@dpdk.org,
stephen@networkplumber.org,
Gaetan Rivet <gaetan.rivet@6wind.com>,
qi.z.zhang@intel.com, arybchenko@solarflare.com,
bruce.richardson@intel.com, shaopeng.he@intel.com, "Burakov,
Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option
Date: Wed, 2 Jan 2019 15:46:06 +0100 [thread overview]
Message-ID: <CAJFAV8yTm1M79Rf--hjgKQD5pv8P3U-=2ZGB675yjepfE8tcCg@mail.gmail.com> (raw)
In-Reply-To: <567955b0-b4c3-4926-bb8f-c99f6ff5c338@intel.com>
Hello Jeff,
On Sat, Dec 29, 2018 at 5:06 AM Jeff Guo <jia.guo@intel.com> wrote:
> On 12/17/2018 6:15 PM, David Marchand wrote:
>
>
> On Fri, Dec 14, 2018 at 8:41 AM Jeff Guo <jia.guo@intel.com> wrote:
>
>> This command-line option will enable hotplug event detecting and enable
>> hotplug handling for device hotplug.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>>
>
> Is there a reason why we would want this disabled by default and enabled
> via option ?
>
>
> Before i can give you an answer, let's see what will bring on if enable
> it.
>
> When enable the hotplug will means that it will bring a new netlink socket
> communication
>
> and a sigbus detecting and specific processing. So if user not want to add
> this work load, just
>
> let it to be optional. Do you agree with that? If not please show what is
> your concern. Thanks.
>
If the user does nothing about the sigbus signal handling but the eal
signal handler was not registered, the dpdk app will end up being
terminated by the kernel.
If the user wants to do its own things and don't want the eal to mess with
it... I am under the impression that he can disable the eal sigbus handler
by calling rte_dev_hotplug_handle_disable().
The netlink stuff is handled in the interrupt thread, no impact on the
processing threads and no additional thread afaics.
--
David Marchand
next prev parent reply other threads:[~2019-01-02 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 7:45 [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug Jeff Guo
2018-12-14 7:45 ` [dpdk-dev] [PATCH 1/3] eal: add --dev-hotplug option Jeff Guo
2018-12-17 10:15 ` David Marchand
2018-12-29 4:06 ` Jeff Guo
2019-01-02 14:46 ` David Marchand [this message]
2018-12-14 7:45 ` [dpdk-dev] [PATCH 2/3] ethdev: remove ethdev rmv interrupt Jeff Guo
2018-12-14 7:45 ` [dpdk-dev] [PATCH 3/3] testpmd: remove device detach into eal Jeff Guo
2019-04-08 14:10 ` [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug Iremonger, Bernard
2019-04-08 14:10 ` Iremonger, Bernard
2023-06-09 17:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yTm1M79Rf--hjgKQD5pv8P3U-=2ZGB675yjepfE8tcCg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=shaopeng.he@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).