From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org,
Gagandeep Singh <g.singh@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Nikhil Agarwal <nikhil.agarwal@amd.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Anoob Joseph <anoobj@marvell.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Abdullah Sevincer <abdullah.sevincer@intel.com>,
Igor Russkikh <irusskikh@marvell.com>,
Steven Webster <steven.webster@windriver.com>,
Matt Peters <matt.peters@windriver.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Apeksha Gupta <apeksha.gupta@nxp.com>,
Junfeng Guo <junfeng.guo@intel.com>,
Simei Su <simei.su@intel.com>, Long Li <longli@microsoft.com>,
Vamsi Attunuru <vattunuru@marvell.com>,
Harman Kalra <hkalra@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Alok Prasad <palok@marvell.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Jochen Behrens <jbehrens@vmware.com>,
Rosen Xu <rosen.xu@intel.com>,
Tianfei Zhang <tianfei.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>
Subject: Re: [PATCH] drivers: use dedicated logtypes
Date: Thu, 1 Feb 2024 10:35:42 +0100 [thread overview]
Message-ID: <CAJFAV8yWBS00c+5bPvYsq=Qc-7DXmfFC3g9sq_ROBuzRjoQbSg@mail.gmail.com> (raw)
In-Reply-To: <20231218135932.1497163-1-david.marchand@redhat.com>
On Mon, Dec 18, 2023 at 2:59 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> When a driver dedicated logtype exists, use it instead of the generic
> PMD logtype.
>
> This has been done partially automatically with:
>
> $ for file in $(git grep -l RTE_LOG.*PMD.*fmt drivers/'**.h' \
> :^drivers/common/cnxk/roc_platform.h)
> do
> tail=${file#drivers/*/*/}
> dir=${file%%$tail}
> ! git grep -q RTE_LOGTYPE_ $dir || \
> { echo $dir already done; continue; }
> git grep -hE '^extern int .*log.*;$' $file | \
> sed -ne 's/^extern int \([^ ;]*\);$/\1/p' | \
> while read logtype
> do
> git grep -q 'RTE_LOG_REGISTER\(_DEFAULT\|\)('$logtype',' || \
> [ "$logtype" != "${logtype%%driver}" ] || \
> { echo Skipped $logtype; continue; }
> abbrev=$(echo $logtype | sed -e 's/_logtype//' | tr '[a-z]' '[A-Z]')
> sed -i -e 's/^\(extern int '$logtype'.*\)$/\1\n#define RTE_LOGTYPE_' \
> $abbrev' '$logtype'/' $file
> sed -i -e 's/\(RTE_LOG.*, \)PMD,/\1'$abbrev',/' $file
> break
> done
> done
>
> Then a manual update for:
> - common/cpt,
> - common/dpaax,
> - common/idpf,
> - mempool/dpaa,
> - net/bnxt,
> - net/octeon_ep,
> - raw/ifpga,
> - vdpa/ifc,
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Rebased and applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-02-01 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 13:59 David Marchand
2023-12-18 17:14 ` Stephen Hemminger
2024-01-12 13:53 ` Maxime Coquelin
2024-02-01 9:35 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yWBS00c+5bPvYsq=Qc-7DXmfFC3g9sq_ROBuzRjoQbSg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=abdullah.sevincer@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=anoobj@marvell.com \
--cc=apeksha.gupta@nxp.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jbehrens@vmware.com \
--cc=jingjing.wu@intel.com \
--cc=junfeng.guo@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=longli@microsoft.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=palok@marvell.com \
--cc=rosen.xu@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sachin.saxena@nxp.com \
--cc=simei.su@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=steven.webster@windriver.com \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
--cc=vattunuru@marvell.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).