From: David Marchand <david.marchand@redhat.com>
To: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
Cc: dev <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6
Date: Tue, 2 Jul 2019 13:46:12 +0200 [thread overview]
Message-ID: <CAJFAV8yWB_d_av2y2qU7KMqynEymxRgU_iydY2oskivaGZz3XA@mail.gmail.com> (raw)
In-Reply-To: <1562066494-25411-1-git-send-email-jananeex.m.parthasarathy@intel.com>
On Tue, Jul 2, 2019 at 1:22 PM Jananee Parthasarathy <
jananeex.m.parthasarathy@intel.com> wrote:
> Unit test table_autotest results in segmentation fault.
> Crash occurs in test_table_lpm_ipv6_combined().
>
> Variable 'nht_pos0' used as array subscript is not initialized
> in rte_table_lpm_ipv6_entry_add(). It will not be assigned,
> if a rule does not exist.
>
> In such case a junk number or invalid array index might result in
> segmentation fault due to array out of bounds when
> lpm->nht_users is used with such invalid array index.
>
> Fix is to initialize the variables used for array subscript.
>
>
Bugzilla ID: 285
Fixes: d89a5bce1d ("lpm6: extend next hop field")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> ---
> lib/librte_table/rte_table_lpm_ipv6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_table/rte_table_lpm_ipv6.c
> b/lib/librte_table/rte_table_lpm_ipv6.c
> index a55f808a4..4e068d79b 100644
> --- a/lib/librte_table/rte_table_lpm_ipv6.c
> +++ b/lib/librte_table/rte_table_lpm_ipv6.c
> @@ -182,7 +182,7 @@ rte_table_lpm_ipv6_entry_add(
> struct rte_table_lpm_ipv6 *lpm = table;
> struct rte_table_lpm_ipv6_key *ip_prefix =
> key;
> - uint32_t nht_pos, nht_pos0, nht_pos0_valid;
> + uint32_t nht_pos = 0, nht_pos0 = 0, nht_pos0_valid = 0;
>
nht_pos_valid is unconditionnally set, no need to initialize.
Just noticed that nht_pos is not initialised to 0 in ipv4 code.
It fixes the segfault I saw, leaving the ack to the maintainer.
Tested-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-07-02 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 11:21 Jananee Parthasarathy
2019-07-02 11:46 ` David Marchand [this message]
2019-07-02 11:50 ` Dumitrescu, Cristian
2019-07-04 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yWB_d_av2y2qU7KMqynEymxRgU_iydY2oskivaGZz3XA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).