From: David Marchand <david.marchand@redhat.com>
To: Ben Pfaff <blp@ovn.org>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev <dev@dpdk.org>,
Ian Stokes <ian.stokes@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD
Date: Mon, 10 May 2021 13:25:28 +0200 [thread overview]
Message-ID: <CAJFAV8yWgMBhLqOAm1b=UuZm_UZSo-BvsKyx1_==qUrgfa+Fxg@mail.gmail.com> (raw)
In-Reply-To: <YJWRTxDW2MYtCMkk@ovn.org>
Hello Ben,
On Fri, May 7, 2021 at 9:13 PM Ben Pfaff <blp@ovn.org> wrote:
> > > > It would be interesting to know exact issue this solves for OVS.
> > > > Referenced commit only says FreeBSD "insists" on this include order,
> > > > but DPDK and standalone files with these includes build either way.
> > >
> > > Indeed, I tried building with FreeBSD 13.0 and I can see no pb.
> > > This might be something that has been fixed in FreeBSD.
> > >
> > > Ben, would you have details on this header inclusion order?
> >
> > Using the wrong order caused a compiler error on whatever version of
> > FreeBSD was current at the time of those commits. I think it was a
> > historical BSD issue, since I remember running into this for many years
> > across multiple BSD versions.
> >
> > If it's fixed now, we can drop the constraint.
I reverted some bits on arpa/inet.h vs netinet/in.h headers in OVS but
did not reproduce the issue on FreeBSD 11 and 12 with Cirrus.
>
> Oh, Mac OS X appears to also have this or a related problem:
Reverting the patch on conntrack which deals with sys/types.h vs
netinet/icmp6.h, there is an issue on FreeBSD 11 and 12:
https://cirrus-ci.com/task/4786810854309888
In file included from lib/conntrack.c:libtool: compile: clang
-DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib
-I/usr/local/include -Wstrict-prototypes -Wall -Wextra
-Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -Wthread-safety -fno-strict-aliasing
-Wswitch-bool -Wlogical-not-parentheses -Wsizeof-array-argument
-Wshift-negative-value -Qunused-arguments -Wshadow
-Wno-null-pointer-arithmetic -Warray-bounds-pointer-arithmetic -Werror
-Werror -g -O2 -Wall -DHAVE_AVX512F -DHAVE_LD_AVX512_GOOD -MT
lib/coverage.lo -MD -MP -MF lib/.deps/coverage.Tpo -c lib/coverage.c
-o lib/coverage.o
21:
/usr/include/netinet/icmp6.h:71:2: error: unknown type name 'u_int8_t'
u_int8_t icmp6_type; /* type field */
^
/usr/include/netinet/icmp6.h:72:2: error: unknown type name 'u_int8_t'
u_int8_t icmp6_code; /* code field */
^
...
I don't think it is worth dropping only the first constraint, so I
would keep it as is in OVS.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-05-10 11:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 15:14 [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-06 15:14 ` [dpdk-dev] [PATCH 1/2] net: add endianness annotations to ethernet headers David Marchand
2021-05-11 13:09 ` Olivier Matz
2021-05-06 15:14 ` [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD David Marchand
2021-05-06 22:23 ` Dmitry Kozlyuk
2021-05-07 9:06 ` David Marchand
2021-05-07 19:12 ` Ben Pfaff
2021-05-07 19:13 ` Ben Pfaff
2021-05-10 11:25 ` David Marchand [this message]
2021-05-11 13:09 ` Olivier Matz
2021-05-07 12:21 ` [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-07 13:15 ` Aaron Conole
2021-05-11 13:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yWgMBhLqOAm1b=UuZm_UZSo-BvsKyx1_==qUrgfa+Fxg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=blp@ovn.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ian.stokes@intel.com \
--cc=ktraynor@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).