From: David Marchand <david.marchand@redhat.com>
To: "Huang, Wei" <wei.huang@intel.com>
Cc: "Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [PATCH] doc: announce some raw/ifpga API removal
Date: Fri, 1 Jul 2022 10:09:48 +0200 [thread overview]
Message-ID: <CAJFAV8yhOS++v_n764s5nxKn+ajL_7q_rQ93q+wqv=K+Xiv8tg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB353022F7379668C9B1B15710EFBD9@DM6PR11MB3530.namprd11.prod.outlook.com>
On Fri, Jul 1, 2022 at 10:02 AM Huang, Wei <wei.huang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Friday, July 1, 2022 15:22
> > To: Huang, Wei <wei.huang@intel.com>
> > Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>;
> > dev@dpdk.org; Ray Kinsella <mdr@ashroe.eu>
> > Subject: Re: [PATCH] doc: announce some raw/ifpga API removal
> >
> > On Fri, Jul 1, 2022 at 9:16 AM Huang, Wei <wei.huang@intel.com> wrote:
> > > > What is the PCI bus used for, in this application?
> > > >
> > > In this application, target PCI device is Intel FPGA, it supports some
> > > special operation like removing it from PCI bus and rescanning it back from PCI
> > bus, So there are two things need to be done directly on rte_pci_bus:
> > > 1. Rescan PCI bus
> > > pci_bus->bus.scan()
> > > 2. Get pci_dev by specified PCI address, and remove it
> > > TAILQ_FOREACH(pci_dev, &pci_bus->device_list, next) {
> > > if (!rte_pci_addr_cmp(&pci_dev->addr, &addr))
> > > return pci_dev;
> > > }
> > > ....
> > > pci_drv = pci_dev->driver;
> > > pci_drv->remove(pci_dev);
> >
> > Can't this application use rte_dev_remove and rte_dev_probe?
> > If not, we should add the missing parts in the API.
> >
> Both rte_dev_remove and rte_dev_probe need rte_device pointer. In this application, it only know the device's PCI address, is there an
> existing API to get the rte_pci_device pointer by its PCI address ?
rte_dev_probe takes a devargs string as input.
int rte_dev_probe(const char *devargs);
You need the rte_device for removing which can be retrieved from
rte_rawdev_info_get.
>
> For PCI rescan, I know there is an API called rte_bus_scan(), which seems to be able to replace pci_bus->bus.scan(). But is it reasonable to scan all buses
> when I want to only scan PCI ?
> Why I need to rescan PCI bus, the answer is current PCI scan only add PCI device to rte_pci_bus when it is bound to kernel driver. In our case, a FPGA
> may not bind to any driver, this application bind vfio-pci to it and call bus scan to add it to rte_pci_bus.
Scanning is called on the relevant bus when probing, see local_dev_probe.
--
David Marchand
next prev parent reply other threads:[~2022-07-01 8:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 9:41 David Marchand
2022-07-01 6:15 ` Xu, Rosen
2022-07-01 6:25 ` Huang, Wei
2022-07-01 7:00 ` David Marchand
2022-07-01 7:16 ` Huang, Wei
2022-07-01 7:21 ` David Marchand
2022-07-01 8:02 ` Huang, Wei
2022-07-01 8:09 ` David Marchand [this message]
2022-07-01 8:14 ` David Marchand
2022-07-01 8:32 ` Huang, Wei
2022-07-01 8:35 ` David Marchand
2022-07-07 9:29 ` David Marchand
2022-07-07 9:34 ` Huang, Wei
2022-07-12 14:24 ` Thomas Monjalon
2022-07-12 15:33 ` Maxime Coquelin
2022-07-16 16:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yhOS++v_n764s5nxKn+ajL_7q_rQ93q+wqv=K+Xiv8tg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).