From: David Marchand <david.marchand@redhat.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter
Date: Fri, 28 Jun 2019 21:22:18 +0200 [thread overview]
Message-ID: <CAJFAV8yj5VgnDmNdruyXt+jmRRWR=WmWVPd4c1D1-mNJb19OdA@mail.gmail.com> (raw)
In-Reply-To: <20190628155056.28884-3-adrien.mazarguil@6wind.com>
On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil <adrien.mazarguil@6wind.com>
wrote:
> Rather than prefixing the return type of function prototypes with
> __rte_experimental, move it to a separate line to enhance readability.
>
> Except for checkpatches.sh, this patch was automatically generated by:
>
> sed -i \
> -e '/^\([^#].*\)\?__rte_experimental */{' \
> -e 's//\1/; s/ *$//; i\' \
> -e __rte_experimental \
> -e '/^$/d}' \
> $(git grep -l __rte_experimental -- '*.h')
>
> And applies on top of below commit:
>
> Fixes: 3b45414830ff ("enforce __rte_experimental at the start of symbol
> declarations")
> Cc: David Marchand <david.marchand@redhat.com>
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
Either way is ok for me.
But if we go with yours, we can squash this patch into mine and avoid this
"va-et-vient".
Thomas, what do you want to do?
Adrien patch1 can be caught in my patch8 by re-running the commands from
the commitlog.
Can you handle it?
--
David Marchand
prev parent reply other threads:[~2019-06-28 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 15:56 [dpdk-dev] [PATCH 0/2] Fix remaining issues with __rte_experimental Adrien Mazarguil
2019-06-28 15:56 ` [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag Adrien Mazarguil
2019-06-28 16:05 ` Stephen Hemminger
2019-06-28 16:23 ` David Marchand
2019-07-01 8:39 ` Adrien Mazarguil
2019-06-28 15:56 ` [dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter Adrien Mazarguil
2019-06-28 19:22 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yj5VgnDmNdruyXt+jmRRWR=WmWVPd4c1D1-mNJb19OdA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).