DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org,  Lincoln Lavoie <lylavoie@iol.unh.edu>,
	techboard@dpdk.org
Subject: Re: [PATCH 1/1] build: increase minimum meson version to 0.53
Date: Fri, 7 Oct 2022 17:49:31 +0200	[thread overview]
Message-ID: <CAJFAV8yrNwiLHz2hCfC7So1R8LyODOFjr0VLBBgapuC68cbEmg@mail.gmail.com> (raw)
In-Reply-To: <Y0BHCQk9mCFqG1ZZ@bricha3-MOBL.ger.corp.intel.com>

On Fri, Oct 7, 2022 at 5:34 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Oct 07, 2022 at 05:26:05PM +0200, David Marchand wrote:
> > On Fri, Oct 7, 2022 at 4:11 PM Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > > - We have an issue with mingw cross compilation.
> > > > https://github.com/ovsrobot/dpdk/actions/runs/3039251235/jobs/4893964186
> > > >
> > > > + meson build --werror --cross-file config/x86/cross-mingw
> > > > -Dexamples=helloworld -Dplatform=generic --default-library=static
> > > > --buildtype=debugoptimized -Dcheck_includes=true
> > > > The Meson build system
> > > > Version: 0.53.0
> > > > Source dir: /home/runner/work/dpdk/dpdk
> > > > Build dir: /home/runner/work/dpdk/dpdk/build
> > > > Build type: cross build
> > > > Program cat found: YES (/usr/bin/cat)
> > > > Project name: DPDK
> > > > Project version: 22.11.0-rc0
> > > > C compiler for the build machine: ccache gcc (gcc 9.4.0 "gcc (Ubuntu
> > > > 9.4.0-1ubuntu1~20.04.1) 9.4.0")
> > > > C linker for the build machine: gcc GNU ld.bfd 2.34
> > > >
> > > > meson.build:4:0: ERROR: Unable to determine dynamic linker
> > > >
> > > >
> > > > - I reproduced locally, it looks like meson is trying to pass some
> > > > -fuse-ld option that is not understood.
> > > > 4577  write(2, "x86_64-w64-mingw32-gcc: error: unrecognized command
> > > > line option \342\200\230-fuse-ld=x86_64-w64-mingw32-ld\342\200\231\n",
> > > > 101) = 101
> > > >
> > > >
> > > > - Upgrading to 0.53.1, I don't see the issue anymore for mingw, so I
> > > > pushed a branch in GHA to get a status for other targets.
> > > > https://github.com/david-marchand/dpdk/actions/runs/3205007946
> > > >
> > > So minimum should be 0.53.1 rather than 0.53 then?
> > >
> >
> > - That's what my test shows.
> > Fyi, 0.53.2 works too.
> >
> As latest point release of 0.53 that is probably better choice.
>
> >
> > - With 0.53, it seems the meaning of the ld variable (in meson config
> > file) changed.
> > I am unclear though if our current configs still make sense.
> >
> Do you want more time to examine this, or shall I respin this patch with
> 0.53.2 as minimum version?

https://github.com/mesonbuild/meson/issues/6442
https://github.com/mesonbuild/meson/pull/6457/commits/8e7a7c36b579c11dd389fcb1152a4e8ead8b8782

I understand that the ld variable meaning has been restored, so
nothing to change for us.

Please respin to 0.53.2, with a note about this issue for posterity.

Thanks.


-- 
David Marchand


  reply	other threads:[~2022-10-07 15:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 17:07 [PATCH 0/1] Update minimum required meson version Bruce Richardson
2022-09-12 17:07 ` [PATCH 1/1] build: increase minimum meson version to 0.53 Bruce Richardson
2022-10-07 13:17   ` David Marchand
2022-10-07 14:11     ` Bruce Richardson
2022-10-07 15:26       ` David Marchand
2022-10-07 15:34         ` Bruce Richardson
2022-10-07 15:49           ` David Marchand [this message]
2022-10-07 16:24 ` [PATCH v2] build: increase minimum meson version to 0.53.2 Bruce Richardson
2022-10-07 19:13   ` David Marchand
2022-10-10  5:23     ` Tu, Lijuan
2022-10-10  7:48       ` David Marchand
2022-10-13 12:51         ` Tu, Lijuan
2022-10-10 14:53     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8yrNwiLHz2hCfC7So1R8LyODOFjr0VLBBgapuC68cbEmg@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lylavoie@iol.unh.edu \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).