From: David Marchand <david.marchand@redhat.com>
To: Yunjian Wang <wangyunjian@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"dingxiaoxiong@huawei.com" <dingxiaoxiong@huawei.com>,
"xudingke@huawei.com" <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ring: fix error return value when creating ring
Date: Sat, 5 Feb 2022 18:04:09 +0100 [thread overview]
Message-ID: <CAJFAV8ytaCEwtqduPrQ0fDDazb+FFFdPm531WVAEry5_OTzVhQ@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB44915682AFA699ABB8E693949A509@DM6PR11MB4491.namprd11.prod.outlook.com>
On Mon, Jan 10, 2022 at 3:15 PM Ananyev, Konstantin
<konstantin.ananyev@intel.com> wrote:
>
> > The error value returned by rte_ring_create_elem() should be positive
> > integers. However, if the rte_ring_get_memsize_elem() function fails,
> > a negative number is returned and is directly used as the return value.
> > As a result, this will cause the external call to check the return
> > value to fail(like called by rte_mempool_create()).
> >
> > Fixes: a182620042aa ("ring: get size in memory")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Nan Zhou <zhounan14@huawei.com>
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2022-02-05 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 9:23 Yunjian Wang
2022-01-10 14:11 ` Ananyev, Konstantin
2022-02-05 17:04 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ytaCEwtqduPrQ0fDDazb+FFFdPm531WVAEry5_OTzVhQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dingxiaoxiong@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).