From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>, bruce.richardson@intel.com
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v2] build: check drivers class dependencies early
Date: Tue, 8 Aug 2023 09:43:25 +0200 [thread overview]
Message-ID: <CAJFAV8yugGH5O55EvN=+=RkX30M_NiSWOnbCs0TqZkDO+StYTQ@mail.gmail.com> (raw)
In-Reply-To: <20230801134133.2860104-1-david.marchand@redhat.com>
On Tue, Aug 1, 2023 at 3:41 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Drivers implementing a class of devices (for example, drivers/event)
> depend on the associated abstraction library (lib/eventdev).
> This dependency is expressed in the top level meson.build for this class
> (drivers/event/meson.build).
>
> As we are making more libraries optional, custom constructs referencing
> the class dependencies in some drivers meson.build (event/dlb2) may break.
>
> It would be possible to add more checks in those drivers meson.build but
> it is more straightforward to not even consider a driver meson.build when
> the class dependencies are not met.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
Bruce, could you rebase your series marking more libraries optional?
There is some conflicts after removal of kni/flow_classify, and adding
a unit test (perf reasm).
--
David Marchand
next prev parent reply other threads:[~2023-08-08 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 8:52 [PATCH] " David Marchand
2023-08-01 9:25 ` Bruce Richardson
2023-08-01 10:20 ` David Marchand
2023-08-01 10:35 ` Bruce Richardson
2023-08-01 10:49 ` Morten Brørup
2023-08-01 11:04 ` Morten Brørup
2023-08-01 13:41 ` [PATCH v2] " David Marchand
2023-08-01 14:01 ` Bruce Richardson
2023-08-02 16:11 ` Tyler Retzlaff
2023-08-08 7:43 ` David Marchand [this message]
2023-08-08 8:07 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yugGH5O55EvN=+=RkX30M_NiSWOnbCs0TqZkDO+StYTQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).