From: David Marchand <david.marchand@redhat.com>
To: Kevin Liu <kevinx.liu@intel.com>, qi.z.zhang@intel.com
Cc: dev@dpdk.org, qiming.yang@intel.com, stevex.yang@intel.com,
beilei.xing@intel.com, jingjing.wu@intel.com,
Mike Pattrick <mkp@redhat.com>,
Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH v2 0/2] check illegal packets
Date: Mon, 18 Sep 2023 16:42:10 +0200 [thread overview]
Message-ID: <CAJFAV8yv1W_OTwXsFC+9V8R+FasEMnVh0Vdxjz-gKCE9zaJ+NQ@mail.gmail.com> (raw)
In-Reply-To: <20220927071522.3656059-1-kevinx.liu@intel.com>
On Tue, Sep 27, 2022 at 9:24 AM Kevin Liu <kevinx.liu@intel.com> wrote:
>
> Check whether the data packet is illegal of ice and iavf driver.
>
> v2:
> Change the scheme, check the data_len and update commit log.
>
> Kevin Liu (2):
> net/iavf: check illegal packets
> net/ice: check illegal packets
>
> drivers/net/iavf/iavf_rxtx.c | 9 +++++++++
> drivers/net/iavf/iavf_rxtx.h | 2 ++
> drivers/net/ice/ice_rxtx.c | 11 +++++++++++
> drivers/net/ice/ice_rxtx.h | 2 ++
> 4 files changed, 24 insertions(+)
This series looks wrong to me.
- What happens if the application requests TSO to the nic?
- Checking data_len of a mbuf means only checking the size of the
first segment, so if any limitation applies to the packet size, it
should by checking pkt_len.
I will probably send reverts for the two patches.
--
David Marchand
next prev parent reply other threads:[~2023-09-18 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 7:04 [PATCH " Kevin Liu
2022-09-22 7:04 ` [PATCH 1/2] net/iavf: " Kevin Liu
2022-09-23 0:46 ` Zhang, Qi Z
2022-09-22 7:04 ` [PATCH 2/2] net/ice: " Kevin Liu
2022-09-27 7:15 ` [PATCH v2 0/2] " Kevin Liu
2022-09-27 7:15 ` [PATCH v2 1/2] net/iavf: " Kevin Liu
2022-09-27 7:15 ` [PATCH v2 2/2] net/ice: " Kevin Liu
2022-09-30 0:21 ` [PATCH v2 0/2] " Zhang, Qi Z
2023-09-18 14:42 ` David Marchand [this message]
2023-09-18 14:51 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yv1W_OTwXsFC+9V8R+FasEMnVh0Vdxjz-gKCE9zaJ+NQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=kevinx.liu@intel.com \
--cc=ktraynor@redhat.com \
--cc=mkp@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).