From: David Marchand <david.marchand@redhat.com>
To: Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dev@dpdk.org
Subject: Re: [PATCH] test/graph: initialize graph param variable
Date: Tue, 7 Feb 2023 14:34:19 +0100 [thread overview]
Message-ID: <CAJFAV8yyozRcudk_=HT_71rDBKCe2exFef1ULS3PtiDdzaOXEA@mail.gmail.com> (raw)
In-Reply-To: <20230203084804.2235611-1-amitprakashs@marvell.com>
On Fri, Feb 3, 2023 at 9:49 AM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> Initializing rte_graph_param variable with 0 to avoid any
> garbage value in structure elements which are not populated
> as part of this function.
Something looks strange to me.
I fail to see which part of this object is not initialised by the test code.
app/test/test_graph_perf.c: struct rte_graph_param gconf;
app/test/test_graph_perf.c: gconf.socket_id = SOCKET_ID_ANY;
app/test/test_graph_perf.c: gconf.nb_node_patterns = graph_data->nb_nodes;
app/test/test_graph_perf.c: gconf.node_patterns = (const char
**)(uintptr_t)node_patterns;
app/test/test_graph_perf.c: graph_id = rte_graph_create(gname, &gconf);
With this struct defined as:
struct rte_graph_param {
int socket_id; /**< Socket id where memory is allocated. */
uint16_t nb_node_patterns; /**< Number of node patterns. */
const char **node_patterns;
/**< Array of node patterns based on shell pattern. */
};
Is this perhaps related to the following series?
https://patchwork.dpdk.org/project/dpdk/list/?series=26783&state=%2A&archive=both
If this is the case, then this fix should be squashed as part of the
rte_graph_param struct extension.
Thanks.
--
David Marchand
prev parent reply other threads:[~2023-02-07 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 8:48 Amit Prakash Shukla
2023-02-07 6:47 ` Jerin Jacob
2023-02-07 13:34 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yyozRcudk_=HT_71rDBKCe2exFef1ULS3PtiDdzaOXEA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).